ice_unittest WebRtcIceGatherTest.TestGatherDNSStunServerIpAddress and WebRtcIceGatherTest.TestGatherDNSStunServerHostname can result in false negative if the machine is behind no NAT
Categories
(Core :: WebRTC: Networking, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox110 | --- | fixed |
People
(Reporter: gorisanson, Assigned: gorisanson)
Details
Attachments
(1 file)
Steps to reproduce:
- Connect to the Internet directly with a public IP (behind no NAT)
- Run
./mach gtest "WebRtcIceGatherTest.TestGatherDNSStunServer*"
Actual results:
WebRtcIceGatherTest.TestGatherDNSStunServerIpAddress
and
WebRtcIceGatherTest.TestGatherDNSStunServerHostname,
both tests failed.
Expected results:
WebRtcIceGatherTest.TestGatherDNSStunServerIpAddress
and
WebRtcIceGatherTest.TestGatherDNSStunServerHostname,
both tests should have passed.
|
Assignee | |
Comment 1•2 years ago
|
||
Set ICE_POLICY_NO_HOST in each test to ensure that an srflx candidate is
not falsely discarded.
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 2•2 years ago
|
||
I found this bug in the unit tests in ice_unittest.cpp when I was making and testing the patch for bug 1742337.
So I'm reporting it and submitting a patch for it.
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
|
Assignee | |
Comment 4•2 years ago
|
||
(In reply to Kyutae Lee [:gorisanson] from comment #3)
Try pushes:
https://treeherder.mozilla.org/jobs?repo=try&revision=65c0efbbf1d9177ed1843ccd876ca3cbeb0d0746
https://treeherder.mozilla.org/jobs?repo=try&revision=1ea5fa339ee6504861fe3f041cbeddbf96c651a4
Oh, I did some mistake in one of the try pushes above.
Please see the try pushes below instead.
Try pushes:
https://treeherder.mozilla.org/jobs?repo=try&revision=65c0efbbf1d9177ed1843ccd876ca3cbeb0d0746
https://treeherder.mozilla.org/jobs?repo=try&revision=4e52a3fabf9371cd612a95ffd48f0e800e05cb79
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77bba94bb760 Fix two tests in ice_unittest.cpp r=webrtc-reviewers,bwc
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
Description
•