1807468 - Flatpak desktop file has duplicate keywords

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[bbhtt]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

The Flatpak desktop file has keywords in two places on line 124 and line 160

https://hg.mozilla.org/mozilla-central/file/tip/taskcluster/docker/firefox-flatpak/org.mozilla.firefox.desktop

This might fail validation which is used by appstream (a warning can be seen while building the flatpak).

$ desktop-file-validate org.mozilla.firefox.desktop 

org.mozilla.firefox.desktop: error: file contains multiple keys named "Keywords" in group "Desktop Entry"

Expected results:

There should be only one keyword key.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[jokeyrhyme]

Yep, this breaks the desktop-file parsing in my launcher, so I can't start Firefox at all until I've manually edited this .desktop file, and I have to do it everytime Firefox is updated

Please remove the Keywords=web;browser;internet; line (I believe the other Keywords= line is superior due to having translations, etc)

Comment 3

[jokeyrhyme]

Attachment: Bug 1807468 - de-duplicate Keywords= in flatpak .desktop r?stransky

Comment 4

[jokeyrhyme]

Okay, well, I seem to have figured out how to submit a patch, yay

We'll see if we can get this approved and merged :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63f9d0c0025a
de-duplicate Keywords= in flatpak .desktop r=stransky

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/63f9d0c0025a