1807648 - [wpt-sync] Sync PR 37683 - Reland "Reject getDisplayMedia calls without user activation"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 37683 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37683
Details from upstream follow.

Fr <[e-mail]> wrote:

Reland "Reject getDisplayMedia calls without user activation"

This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1.

Reason for revert: Fixing permission policy tests

Original change's description:

Revert "Reject getDisplayMedia calls without user activation"

This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf.

Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7.

The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related.

Original change's description:

Reject getDisplayMedia calls without user activation

This CL makes sure getDisplayMedia() returned promise reject with
InvalidStateError when called without user activation.
Note that speculation rules tests are updated as well[1].

[1] https://github.com/WICG/nav-speculation/issues/225

Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI

Bug: 1198918
Change-Id: I530761d95e6db412582d0f19c0170803516c33f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797
Reviewed-by: Dale Curtis \<[e-mail]>
Reviewed-by: Hiroki Nakagawa \<[e-mail]>
Reviewed-by: Elad Alon \<[e-mail]>
Commit-Queue: Fr \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1086033}

Bug: 1198918
Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423
Auto-Submit: Peter Williamson \<[e-mail]>
Quick-Run: Peter Williamson \<[e-mail]>
Commit-Queue: Rubber Stamper \<[e-mail]>
Owners-Override: Peter Williamson \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1086147}

Bug: 1198918
Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7

Reviewed-on: https://chromium-review.googlesource.com/4125755
WPT-Export-Revision: 6fa6a9fcacdcd4c3588a5175c8f049c0011fb8dc

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=64ec64924f7bf9d28dd2a7edf41d75bbe0aa7118

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 88 tests and 1 subtests

## Status Summary

### Firefox
`OK`     : 53[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 59[GitHub]
`PASS`   : 48[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 51[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 58[GitHub]
`FAIL`   : 488[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 491[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 519[GitHub]
`TIMEOUT`: 41[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 81[GitHub]
`ERROR`  : 1[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 5[GitHub]
`NOTRUN` : 1[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 17[GitHub]

### Chrome
`OK`     : 69
`PASS`   : 231
`CRASH`  : 5
`FAIL`   : 389
`TIMEOUT`: 28
`ERROR`  : 5
`NOTRUN` : 17

### Safari
`OK`     : 59
`PASS`   : 63
`FAIL`   : 514
`TIMEOUT`: 81
`ERROR`  : 5
`NOTRUN` : 17

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=64ec64924f7bf9d28dd2a7edf41d75bbe0aa7118)
[GitHub PR Head](https://wpt.fyi/results/?sha=3812a65a7a727b5873fcd36eca69c2d00880b1a8&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=3812a65a7a727b5873fcd36eca69c2d00880b1a8&label=pr_base)

## Details

### Firefox-only Failures
* [/permissions-policy/payment-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html](https://wpt.live/permissions-policy/payment-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/payment-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html)]
  * permissions policy allow="payment" allows same-origin navigation in an iframe.: `FAIL`
  * permissions policy allow="payment" allowpaymentrequest=true allows same-origin navigation in an iframe.: `FAIL`
* [/permissions-policy/payment-allowed-by-permissions-policy-attribute.https.sub.html](https://wpt.live/permissions-policy/payment-allowed-by-permissions-policy-attribute.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/payment-allowed-by-permissions-policy-attribute.https.sub.html)]
  * permissions policy "payment" can be enabled in same-origin iframe using allow="payment" attribute: `FAIL`
* [/permissions-policy/payment-allowed-by-permissions-policy.https.sub.html](https://wpt.live/permissions-policy/payment-allowed-by-permissions-policy.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/payment-allowed-by-permissions-policy.https.sub.html)]
  * permissions policy header "payment=*" allows the top-level document.: `FAIL`
  * permissions policy header "payment=*" allows same-origin iframes.: `FAIL`
* [/permissions-policy/payment-default-permissions-policy.https.sub.html](https://wpt.live/permissions-policy/payment-default-permissions-policy.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/payment-default-permissions-policy.https.sub.html)]
  * Default "payment" permissions policy allows the top-level document.: `FAIL`
  * Default "payment" permissions policy allows same-origin iframes.: `FAIL`
  * Default "payment" permissions policy allowpaymentrequest=true allows same-origin iframes.: `FAIL`
* [/permissions-policy/picture-in-picture-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html](https://wpt.live/permissions-policy/picture-in-picture-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/picture-in-picture-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html)]
  * permissions policy allow="picture-in-picture" disallows cross-origin navigation in an iframe.: `FAIL`
* [/permissions-policy/picture-in-picture-disabled-by-permissions-policy.https.sub.html](https://wpt.live/permissions-policy/picture-in-picture-disabled-by-permissions-policy.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/picture-in-picture-disabled-by-permissions-policy.https.sub.html)]
  * permissions policy header: picture-in-picture "none" disallows same-origin iframes.: `FAIL`
  * permissions policy header: picture-in-picture "none" disallows cross-origin iframes.: `FAIL`
* [/screen-wake-lock/wakelock-disabled-by-permissions-policy.https.html](https://wpt.live/screen-wake-lock/wakelock-disabled-by-permissions-policy.https.html) [[wpt.fyi](https://wpt.fyi/results/screen-wake-lock/wakelock-disabled-by-permissions-policy.https.html)]
  * Permissions-Policy header "screen-wake-lock=()" disallows the top-level document.: `FAIL`

(See attachment for full changes)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3979562afed9
[wpt PR 37683] - Reland "Reject getDisplayMedia calls without user activation", a=testonly
https://hg.mozilla.org/integration/autoland/rev/3cd90909aa73
[wpt PR 37683] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3979562afed9
https://hg.mozilla.org/mozilla-central/rev/3cd90909aa73