1807697 - Windows and other items disappear from Window menu due to dynamic WebRTC Window "Tab sharing devices" menu item

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Attachment: Proposed new location under Tools for "Tabs sharing devices" menu item

+++ This bug was initially created as a clone of Bug #1800550 +++

WebRTC dynamically adds a "Tab sharing devices" menu item to the Window menu on macOS. Since bug 1642138, macOS manages the list of windows in the Window menu for us. However, this stops working if we dynamically modify the list of menu items. Therefore, the WebRTC menu item should move to another menu. I propose to move this to the "Tools" menu, as seen in the attached picture. I will post a patch for discussion on Phabricator.

Fixing this bug may or may not address bug 1800550. I'm waiting to get confirmation of this in bug 1800550, but I thought it would be important to get the conversation started about where to move this menu item to, hence this bug.

Comment 1

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Try build with this change:

https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PytFc9mkQyqGJ6AzwfQ2ig/runs/0/artifacts/public/build/target.dmg

Comment 2

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Attachment: Bug 1807697: Move the 'Tabs sharing devices' menu item for WebRTC from the Window menu to the Tools menu on macOS. r=Gijs

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1642138

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e15c46e9f7e4
Move the 'Tabs sharing devices' menu item for WebRTC from the Window menu to the Tools menu on macOS. r=Gijs

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e15c46e9f7e4

Comment 7

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Comment on attachment 9309912 [details]
Bug 1807697: Move the 'Tabs sharing devices' menu item for WebRTC from the Window menu to the Tools menu on macOS. r=Gijs

Beta/Release Uplift Approval Request

• User impact if declined: The Window menu on macOS becomes corrupted if a user uses WebRTC, losing the list of open windows and other functionality exposed by macOS such as tiling of windows etc. Recovering the Window menu is not straightforward and may at times require a restart of Firefox before full functionality is restored.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Click the "User gesture" button at https://jan-ivar.github.io/dummy/gdm.html

2. Share a window. You may need to first enable screen sharing in macOS preferences.
3. Open the Window menu and verify that the menu contains the full list of open windows.
4. Open the Tools menu and verify that it contains a new menu item "Tabs sharing devices", listing the window that was shared.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change simply moves an existing menu item from the Window menu to the Tools menu on macOS only.
• String changes made/needed: none
• Is Android affected?: No

Comment 8

[Bogdan Maris, Desktop Test Engineering]

Verified that using the latest Nightly 110.0a1 on macOS 13.1 and macOS 11.6 the "Tabs sharing devices" menu is now located in Tools.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9309912 [details]
Bug 1807697: Move the 'Tabs sharing devices' menu item for WebRTC from the Window menu to the Tools menu on macOS. r=Gijs

Approved for 109.0b8.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/86ee57a6a9a6

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9309912 [details]
Bug 1807697: Move the 'Tabs sharing devices' menu item for WebRTC from the Window menu to the Tools menu on macOS. r=Gijs

Approved for 108.0.2

Comment 12

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-release/rev/966c41ecd357

Comment 13

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: tabs sharing devices.png

Verified that the "Tabs sharing devices" menu is now located in Tools with Firefox 109.0b8 and Firefox 108.0.2 on macOS 11.7.2. Although when accessing the menu it will show a slim bar and not showing the tab like it is looks in the attachment in Comment 0. Here's an attachment of how it looks. Any idea Spohl?

Comment 14

[Stephen A Pohl [:spohl] (OOO until 2/27)]

(In reply to Catalin Sasca, QA [:csasca] from comment #13)

Created attachment 9310778 [details]
tabs sharing devices.png

Verified that the "Tabs sharing devices" menu is now located in Tools with Firefox 109.0b8 and Firefox 108.0.2 on macOS 11.7.2. Although when accessing the menu it will show a slim bar and not showing the tab like it is looks in the attachment in Comment 0. Here's an attachment of how it looks. Any idea Spohl?

Are you able to reproduce this with a build before my change if you share the exact same tab/window/desktop? This might depend on the type of tab, window or desktop that is being shared and is most likely unrelated to my change.

Comment 15

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Yep, tried on Firefox 109.0b5 where the "Tabs sharing devices" menu is located in Window. Seems to be the same there as well. Will mark this as verified then. Do you know if there is an issue logged for the situation mentioned above or should I create one? Thanks!

Comment 16

[Stephen A Pohl [:spohl] (OOO until 2/27)]

(In reply to Catalin Sasca, QA [:csasca] from comment #15)

Yep, tried on Firefox 109.0b5 where the "Tabs sharing devices" menu is located in Window. Seems to be the same there as well. Will mark this as verified then. Do you know if there is an issue logged for the situation mentioned above or should I create one? Thanks!

Unfortunately I don't know, but the folks working on WebRTC might. If you file the bug under Core : WebRTC it will get triaged and duplicated to another bug if it is already filed. Thanks for verifying!