1807791 - [fur, sc] Set up search engines for Friulian (fur), Sardinian (sc)

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Francesco Lodolo [:flod]]

We plan to ship Sardinian (sc) to GA soon, with Friulian (fur) probably short after.

Both languages are spoken mainly in Italy, so I would like to copy the current settings used for Italian (it), including Wikipedia. Both locales have a localized version of Wikipedia, but with a very small amount of articles (3k and 7k, vs 1.7M for Italian).

Comment 1

[James Teow [:jteow]]

Attachment: Bug 1807791 - Add Friulian and Sardinian to search-config - r?standard8

Comment 2

[James Teow [:jteow]]

Hi QA,

I've put Sardinian and Friulian locale codes in search-config on Stage.

Flod mentioned having similar behaviour for it, so what I've done is mimicked explicit references to it locales in search-config.

Amazon has an Italian version, but it's reliant on the users region not their locale.

Thus here are the changes specific to the addition of the two locales:

• Bing: Use the users locale. No concept of Italian Bing, just making sure telemetry is consistent.
• eBay: Use the users locale to load Italian eBay.
• Wikipedia: Use the users locale to load Italian Wikipedia.

Comment 3

[Adrian Florinescu [:aflorinescu]]

Thanks you James,
We'll pick this up soonish - most likely more toward EOW - our understanding is that the localisations for Sardinian (sc) and Friulian (fur) will only be available from 111 onwards, so the priority for this is lower than the rest of this week's tasks.

Comment 4

[Adrian Florinescu [:aflorinescu]]

Tested the changes with search-config pointed to stage preview with 111.0a1 (2023-01-27), using sc and fur localizations with different regions: RO, DE, IT, US, DK, CA .

• amazon is region based
• ebay locale based - it version loaded
• wikipedia locale based - it version loaded.

Covered with a small telemetry smoke testing for default main engines - bing, google, ddg, with no issues found.

One note related to this is that in case the localization is installed but the updated search-config is not immediately available(unupdated dump), the sc, fur or any other language not in the search-config is handled as default/region, which is the expected behavior: for example, now with search-cinfig production -> sc/any_region would be handled as default/any_region.

In regards to production rediness, I think this change is ready.

Comment 5

[James Teow [:jteow]]

Thanks Adrian, I've added the change to Production whereby it's awaiting review.

Comment 6

[James Teow [:jteow]]

The updates to search config Prod were approved on February 2nd.

Just awaiting the update to the dump file to land on Central before landing updates to tests.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a40b2988ea48
Add Friulian and Sardinian to search-config - r=Standard8

Comment 8

[James Teow [:jteow]]

Comment on attachment 9312229 [details]
Bug 1807791 - Add Friulian and Sardinian to search-config - r?standard8

Beta/Release Uplift Approval Request

• User impact if declined: Some tests in toolkit/components/search/tests/xpcshell/searchconfigs/ will break with the latest search-config.json update -> https://hg.mozilla.org/integration/autoland/rev/08f303fe00db38927773e5791ae801b8b162570d

The tests for these have to be landed along with the search-config.json updates.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): These changes are specific to tests.
• String changes made/needed:
• Is Android affected?: Yes

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Some tests in toolkit/components/search/tests/xpcshell/searchconfigs/ will break with the latest search-config.json update -> https://hg.mozilla.org/integration/autoland/rev/08f303fe00db38927773e5791ae801b8b162570d

The tests for these have to be landed along with the search-config.json updates.

• User impact if declined:
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): These are changes specific to tests.

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9312229 [details]
Bug 1807791 - Add Friulian and Sardinian to search-config - r?standard8

Approved for release and esr102 before building our RCs. As we are in RC week and the final merge is competed, the beta repo is now closed until the final merge next Monday and no builds will be created from mozilla-beta this week.

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/0591893a3f3e

Comment 11

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-esr102/rev/6eac40e76123

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a40b2988ea48

Comment 13

[Adrian Florinescu [:aflorinescu]]

Seems like we can't actually test this until fur and sc builds are available and that will be happening only with 111 -> see bug 1811449. Regardless, this issue was tracking the search-config part to accomodate the fur/sc search-configs when loaded into those locales, part which was thouroughly tested anyways on stage and prod-preview.
Although a bit missleading due to the fact that the search-config change has been tested, morphing the qe+ into a qe-.