1807802 - Port |Bug 1469287 - Implement new shared tree styling| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Ian Neal]

Bug 1469287 removes some stylings, especially the Windows Explorer styling, and moves the twisties. Also the treeitem will be a lot taller (24px). See Bug 1483332 for TB's version.

Comment 1

[Ian Neal]

Attachment: 1807802-shared-tree-styling-25316.patch

[Approval Request Comment]
Regression caused by (bug #): 1469287
User impact if declined: styling has changed
Testing completed (on m-c, etc.): 2.53.16
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

From the linux side the only change needed is for the minimum row height. Potentially more might be needed on Windows side but that code may be unused now.

Comment 2

[Ian Neal]

Attachment: 1807802-shared-tree-styling-cc.patch

For c-c - update css for some other trees.
Also fix positioning of twisty following change from 9px to 8px.

Comment 3

[Ian Neal]

Attachment: TOP-1807802-shared-tree-styling-25316.patch

Plaster toolkit for 2.53.x

Comment 4

[Ian Neal]

Attachment: 1807802-shared-tree-styling-v1_1-25316.patch

Fix for mailnews in classic theme as suggested on IRC.

Comment 5

[Ian Neal]

Attachment: 1807802-shared-tree-styling-v1_2-25316.patch

Add macOS changes for classic theme

Comment 6

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9310298 [details] [diff] [review]
TOP-1807802-shared-tree-styling-25316.patch

Easy to see that it works :) LGTM r/a+ for our release branch

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9310297 [details] [diff] [review]
1807802-shared-tree-styling-cc.patch

LGTM
Unable to test there naturally but these are the bits we can't cover with a patch in the mozilla css which we do for 2.53.x

Comment 8

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9310428 [details] [diff] [review]
1807802-shared-tree-styling-v1_2-25316.patch

LGTM The tree lines look a little light here on the mac but might be the monitor and the twisty could shed some width but nothing to worry about. r=a/+

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/de5c56d52fae
Port |Bug 1469287 - Implement new shared tree styling| to SeaMonkey. r=frg

Comment 10

[Frank-Rainer Grahl (:frg)]

2.53 mozilla-release branch
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/f9e26ae21f104d83d2bd7c2c9b355d6bc3bbcf7e
Implement new shared tree styling - classic theme fixes. r=frg a=frg

comm-release branch
https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/dd662147c680d8a158de6838dd6c244c55b37852
Implement new shared tree styling for SeaMonkey. r=frg a=frg