1807942 - WebGL/PDF.js in VMWare VM: Main process crash in gbm_bo_get_fd

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[hurui200320]

Steps to reproduce:

Access https://www.jetbrains.com/idea/

Note: I asked my friend to test it. On fedora, with Xorg, it didn't crash, but it used a lot of CPU and lagged the whole computer. With Wayland, everything is fine. I'm using a VMWare VM.

Related crash report: https://crash-stats.mozilla.org/report/index/77169fdf-ddac-4683-ba93-a4fca0221229

It's worth noticing that all crashes happen in VM, specifically VMWare's VM.

Actual results:

The website started loading, and during the rendering, it crashed.

Expected results:

It should load the website normally. Mac and Windows version is fine, no issue at all.

Comment 1

[hurui200320]

Also, disabling hardware acceleration fixed the crash.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a crash signature, thus the bug will be considered confirmed.

Comment 4

[Alice0775 White]

I can reproduce the crash on Nightly111.0a1 Ubuntu22.04 Japanese VMWare client.

STR.

1. Open https://www.africau.edu/images/default/sample.pdf

Actual:
Browser crashes bp-6208877c-0345-4793-9ec0-74c260230207

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Please run on terminal with MOZ_LOG="Dmabuf:5" and attach the log here.
Thanks.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Can you please attach content of about:support page from Firefox on VMWare's VM?
Thanks.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1807942 [Linux] Don't crash when mGbmBufferObject is missing in DMABufSurfaceRGBA r?emilio

Comment 8

[Martin Stránský [:stransky] (ni? me)]

The patch here ensures we don't crash but I wonder why - looks like eglExportDMABUFImage is broken and does not export dmabuf file descriptors.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1807942 [Linux] Don't use dmabuf surface if ExportDMABUFImageMESA() fails to export dmabuf file descriptors r?emilio

Depends on D169314

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6611ee841e4e
[Linux] Don't crash when mGbmBufferObject is missing in DMABufSurfaceRGBA r=emilio
https://hg.mozilla.org/integration/autoland/rev/8b26c9205d0d
[Linux] Don't use dmabuf surface if ExportDMABUFImageMESA() fails to export dmabuf file descriptors r=emilio

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/6611ee841e4e
https://hg.mozilla.org/mozilla-central/rev/8b26c9205d0d

Comment 12

[Martin Stránský [:stransky] (ni? me)]

https://crash-stats.mozilla.org/report/index/82ad4d50-4d20-47bc-8f14-dba760230224
topcrash on linux, we should uplift.

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9316756 [details]
Bug 1807942 [Linux] Don't crash when mGbmBufferObject is missing in DMABufSurfaceRGBA r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: Crashes on VMware OpenGL emulation where broken DRI is used.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We just check null pointer access.
• String changes made/needed:
• Is Android affected?: Yes

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Err, sorry, looks like beta is already 111 :)

Comment 15

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9316756 [details]
Bug 1807942 [Linux] Don't crash when mGbmBufferObject is missing in DMABufSurfaceRGBA r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: Crashes on VMware OpenGL emulation where broken DRI is used.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We just check null pointer access.
• String changes made/needed:
• Is Android affected?: Yes

Comment 16

[Pascal Chevrel:pascalc]

Comment on attachment 9316757 [details]
Bug 1807942 [Linux] Don't use dmabuf surface if ExportDMABUFImageMESA() fails to export dmabuf file descriptors r?emilio

Approved for our 110.0.1 dot release, thanks.

Comment 17

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/11459bfbb767
https://hg.mozilla.org/releases/mozilla-release/rev/9c8395b9f3e8

Comment 18

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 110.0 on Ubuntu 22.04.2 LTS VMware client by opening https://www.jetbrains.com/idea/ and https://www.africau.edu/images/default/sample.pdf. Crash report id 0527a077-25ca-4f51-b5dc-2c7b80230228.

Verified fixed on the same VMware system with Ubuntu 22.04.2 LTS by using Firefox 110.0.1 (20230227191043) and Firefox 111.0b6 while opening https://www.jetbrains.com/idea/ and https://www.africau.edu/images/default/sample.pdf. No crashes occur when opening the pages.