1808053 - Answer with no codecs in common with offer causes tab crash on debug builds

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P3)

Description

[Byron Campen [:bwc]]

This is a pretty silly bug. Either we should be throwing when such an answer is set (RFC 3264 says there must be at least one codec in common if the m-section is receiving), or we should treat it as a rejected m-section. Since this is a violation of RFC 3264, the right thing is probably to throw.

Comment 1

[Byron Campen [:bwc]]

I should note that I don't see this crash on crash-stats, which is nice I guess.

Comment 2

[Byron Campen [:bwc]]

Try looks fine:
https://treeherder.mozilla.org/jobs?repo=try&revision=5d788aca4f4321c04e07d808e95d7ddfd318d0e4
https://treeherder.mozilla.org/jobs?repo=try&revision=9d571b6df8ed7713e0aaf4543a4812bf63bd4202
https://treeherder.mozilla.org/jobs?repo=try&revision=1a2d86f3047c60f955d15808dcdaae73a7efc0fb

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1808053: Test case for bug. r?mjf

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 1808053: Throw if a non-rejected answer msection contains no codec in common with offer. r?mjf

Depends on D165992

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e9b458590ac
Test case for bug. r=mjf
https://hg.mozilla.org/integration/autoland/rev/0608c14183e2
Throw if a non-rejected answer msection contains no codec in common with offer. r=mjf

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/3e9b458590ac
https://hg.mozilla.org/mozilla-central/rev/0608c14183e2