Closed Bug 1808410 Opened 1 year ago Closed 10 months ago

Support Anonymous View Progress Timelines

Categories

(Core :: CSS Transitions and Animations, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: boris, Assigned: boris)

References

(Blocks 1 open bug, )

Details

(Keywords: dev-doc-needed)

Attachments

(3 files, 1 obsolete file)

Support view() notation for animation-timeline.

https://drafts.csswg.org/scroll-animations-1/#view-notation

Keywords: dev-doc-needed

We store animation and transition style values in StyleUIReset and
define their properties in longhands/ui.mako.rs, so let's move the
definition of their values from values/{specified|computed}/box.rs to
values/{specified|computed}/ui.rs.

Support view() notation for animation-timeline:
<view()> = view( [ <axis> || <'view-timeline-inset'> ]? )

We move AnimationTimeline and its related types into the generics folder,
and define two new structs for scroll() and view().

Note:

  1. The syntax of scroll() doesn't match the current version of the spec.
    I will update it in the next patch.
  2. We will handle the creation/usage of the Anonymous View Progress Timelines
    in the later patch.

The order of <scroller> and <axis> doesn't matter in the parser.
However, we serialize <scroller> first, if it is not the initial value.

Comment on attachment 9325575 [details]
Bug 1808410 - Part 4: Update the syntax of scroll().

Revision D173906 was moved to bug 1814444. Setting attachment 9325575 [details] to obsolete.

Attachment #9325575 - Attachment is obsolete: true
Assignee: nobody → boris.chiou
Status: NEW → ASSIGNED
Attachment #9325572 - Attachment description: Bug 1808410 - Part 1: Move animation-related values from box.rs to ui.rs. → Bug 1808410 - Part 1: Move animation-related values from box.rs/ui.rs to animation.rs.
Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b9091811f503
Part 1: Move animation-related values from box.rs/ui.rs to animation.rs. r=emilio
https://hg.mozilla.org/integration/autoland/rev/259614987813
Part 2: Add animation-timeline: view() in style system. r=emilio
https://hg.mozilla.org/integration/autoland/rev/c0074ece8dd2
Part 3: Create timeline for view(). r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39815 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
Upstream PR merged by moz-wptsync-bot

Is this feature complete, I have added the layout.css.scroll-driven-animations.enabled and it does not seem to be working.
I am using this codepen, to test the expected behaviour. I can see this working in Chrome Canary.

Flags: needinfo?(boris.chiou)

(In reply to Dave Letorey from comment #10)

Is this feature complete, I have added the layout.css.scroll-driven-animations.enabled and it does not seem to be working.
I am using this codepen, to test the expected behaviour. I can see this working in Chrome Canary.

Same as my comment in https://bugzilla.mozilla.org/show_bug.cgi?id=1737920#c12. Drop entry and exit from the keyframes, and set a duration other than 0s, the animation should work.

Flags: needinfo?(boris.chiou)

(In reply to Boris Chiou [:boris] from comment #11)

(In reply to Dave Letorey from comment #10)

Is this feature complete, I have added the layout.css.scroll-driven-animations.enabled and it does not seem to be working.
I am using this codepen, to test the expected behaviour. I can see this working in Chrome Canary.

Same as my comment in https://bugzilla.mozilla.org/show_bug.cgi?id=1737920#c12. Drop entry and exit from the keyframes, and set a duration other than 0s, the animation should work.

Thank you

You need to log in before you can comment on or make changes to this bug.