180846 - Hitting the stop button does not fire onload event.

Status: RESOLVED WORKSFORME

(Core :: DOM: Navigation, defect)

Description

[Thamer Mahmoud]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021101
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021101

Popup blocking behavior should be the same whether a page is stopped or has
finished loading. 

For example, this bug becomes really annoying if you have a slowass diel-up
connection. Because then you'd have to wait for all the images and ads to finish
loading just to be able to open up a text-only popup. 


Reproducible: Always

Steps to Reproduce:

While "block unrequested windows" is active...

1. Goto http://news.yahoo.com/ 
2. Click on the STOP button before the page has finished loading.
3. Click on a slideshow image (below the "News for kids" link)
Actual Results:  
popup is blocked.

Expected Results:  
popup is allowed (since page is not loading)

Comment 1

[Boris Zbarsky [:bzbarsky]]

to docshell... The problem is that Stop() does not fire the onload event, so the
window thinks the page is still loading...

Comment 2

[OstGote!]

(In reply to comment #1)
> to docshell... The problem is that Stop() does not fire the onload event, so the
> window thinks the page is still loading...
And block the popup, see bug 101190.

Comment 3

[Boris Zbarsky [:bzbarsky]]

jst, is this still an issue with your patch?  Now that we have the popup
"whitelist", can we remove the "while page is loading" thing altogether?

Comment 4

[Johnny Stenback (:jst)]

There's no more code in the backend for the popupblocker that cares if the
document is loading or not, but there might be some elsewhere.

Code that might still cause this is code that uses
nsPIDOMWindow::IsLoadingOrRunningTimeout(), which is probably bogus by now, at
least incorrectly named, as is the pref to turn on popup blocking.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Well, chances are this bug is actually fixed by the bug 252326 patch.

nsPIDOMWindow::IsLoadingOrRunningTimeout seems to be largely used by the front
end for some sort of popup UI... I suspect that we want to replace it with some
sort of getter of the popup state...  Probably need a bug on that.

Comment 6

[Boris Zbarsky [:bzbarsky]]

WFM per comment 5.  The current summary is wontfix.