1808557 - Converting an email to a task does not work if the email has several parts

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[adrien.rybarczyk]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36

Steps to reproduce:

1. Have a message containing several part (Example: Content-Type: multipart/alternative;
   boundary="------------Nu7yz33AIGy0jYkZBaHf7PDJ")
2. Convert the email into a task via the existing menu

Actual results:

The task description will contain the boundary of the multipart and will contain only that. So there will be no information from the email.

Expected results:

The problem exists only in beta. In 102.6.1, the feature works perfectly.

Comment 1

[Magnus Melin [:mkmelin]]

Can you attach a sample .eml that shows the issue?

Comment 2

[adrien.rybarczyk]

Attachment: test-2023-01-05.eml

Comment 3

[Magnus Melin [:mkmelin]]

Alice, can you find the regression window?
STR: put the sample .eml in a mail folder, then use the context menu Convert to > Task, and notice the body of the new event is showing the boundary="......" when it's should be showing "Hello"

Comment 4

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=1927091bd8426e62564635cf7c6715e6ef80c9bf&tochange=364bcd649780c4bff1cf3d830cf34160c6abaf6b
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4c9d3b27101023ec9d8a845b531e2f3e364cb958&tochange=e41a026123699f325cc4931a405d41c69ac729c5

Comment 5

[Magnus Melin [:mkmelin]]

Thanks Alice! This would be a regression from bug 1800606.

Comment 6

[adrien.rybarczyk]

Still present in 111

Comment 7

[Wayne Mery (:wsmwk)]

Thanks for the update. We prefer to have version set to the earliest known occurrence of the issue.

Comment 8

[adrien.rybarczyk]

Still present in 114
However, I have just noticed that the button is no longer accessible by right-clicking on the email. You have to use the More menu.

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: Bug 1808557 - Make convert message to event/task work again for multipart messages. r=aleca

Makes conversion work (either through More | Convert To, or dnd of message on the Today pane).

We only want to use extracted content we got once. On furhter onDataAvailable we just need to consume the stream really.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2eaade4a491a
Make convert message to event/task work again for multipart messages. r=aleca

Comment 11

[Magnus Melin [:mkmelin]]

Comment on attachment 9339815 [details]
Bug 1808557 - Make convert message to event/task work again for multipart messages. r=aleca

[Approval Request Comment]
Regression caused by (bug #): bug 1800606
User impact if declined: non working feature
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): pretty safe

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9339815 [details]
Bug 1808557 - Make convert message to event/task work again for multipart messages. r=aleca

[Triage Comment]
Approved for beta

Comment 14

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/bbe8d3c8ab8e