1808565 - Add support for StaticRange in Selection

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Description

[Jan Jaeschke [:jjaschke]]

The Custom Highlight API dictates that highlights can be created from AbstractRanges, i.e. both static and dynamic ranges. Internally, highlights are implemented as a Selection. Selections currently only support dynamic ranges (nsRange), not StaticRanges. Therefore, support for StaticRanges in Selection must be added to support the Highlight API.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1808565, part 1: Adapt `Selection` to support `StaticRange`s. r=masayuki

This change is necessary to support the CSS Highlight API,
which uses Selection internally.

To replace nsRange with AbstractRange, some sections needed to be
adapted since nsRange-specific features were used.
Therefore, some methods (such as GetRangeAt()) may only be called if
the Selection is not of type SelectionType::eHighlight,
as it (per spec) returns an nsRange.
These methods will now MOZ_ASSERT if called for a highlight selection.
Additional methods are implemented which return AbstractRange
instead and are safe to be called for every selection type.

This commit also improves support of highlight features:

• Invalidation of highlight ranges: adding/removing Ranges in-place instead of
  removing and re-adding the Selection object associated with the highlight.
• Ranges are only associated with the Selection that shares the same Document
• Fixed minor IDL issue

Comment 2

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1808565, part 2: Use `SelectionBatcher` when updating Highlights. r=masayuki

Depends on D170582

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0efd5366ad0
part 1: Adapt `Selection` to support `StaticRange`s. r=webidl,saschanaz,masayuki,smaug
https://hg.mozilla.org/integration/autoland/rev/328335bf81de
part 2: Use `SelectionBatcher` when updating Highlights. r=masayuki

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d0efd5366ad0
https://hg.mozilla.org/mozilla-central/rev/328335bf81de