Closed Bug 1808599 Opened 3 years ago Closed 3 years ago

Perma [Tier-2] /trusted-types/trusted-types-event-handlers.tentative.html | Event handler div.ontouchstart should be blocked.

Categories

(Core :: DOM: Security, defect, P5)

defect

Tracking

()

RESOLVED INCOMPLETE
Tracking Status
firefox-esr102 --- unaffected
firefox108 --- unaffected
firefox109 --- unaffected
firefox110 --- wontfix
firefox111 --- wontfix

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression, Whiteboard: [domsecurity-intermittent])

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=401370129&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/FNpRh7FiRgm6dacEAKqQzQ/runs/0/artifacts/public/logs/live_backing.log


[task 2023-01-04T19:04:02.752Z] 19:04:02     INFO - TEST-PASS | /trusted-types/trusted-types-event-handlers.tentative.html | Non-event handler div.tabIndex should not be blocked. 
[task 2023-01-04T19:04:02.752Z] 19:04:02     INFO - TEST-FAIL | /trusted-types/trusted-types-event-handlers.tentative.html | Event handler div.onerror should be blocked. - assert_throws_js: function "_ => element.setAttribute(name, "2+2")" did not throw
[task 2023-01-04T19:04:02.752Z] 19:04:02     INFO - @http://web-platform.test:8000/trusted-types/trusted-types-event-handlers.tentative.html:43:23
[task 2023-01-04T19:04:02.752Z] 19:04:02     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2591:25
[task 2023-01-04T19:04:02.752Z] 19:04:02     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-01-04T19:04:02.752Z] 19:04:02     INFO - @http://web-platform.test:8000/trusted-types/trusted-types-event-handlers.tentative.html:42:9
[task 2023-01-04T19:04:02.752Z] 19:04:02     INFO - TEST-UNEXPECTED-FAIL | /trusted-types/trusted-types-event-handlers.tentative.html | Event handler div.ontouchstart should be blocked. - assert_throws_js: function "_ => element.setAttribute(name, "2+2")" did not throw
[task 2023-01-04T19:04:02.752Z] 19:04:02     INFO - @http://web-platform.test:8000/trusted-types/trusted-types-event-handlers.tentative.html:43:23
[task 2023-01-04T19:04:02.752Z] 19:04:02     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2591:25
[task 2023-01-04T19:04:02.752Z] 19:04:02     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-01-04T19:04:02.752Z] 19:04:02     INFO - @http://web-platform.test:8000/trusted-types/trusted-types-event-handlers.tentative.html:42:9
[task 2023-01-04T19:04:02.753Z] 19:04:02     INFO - 
[task 2023-01-04T19:04:02.754Z] 19:04:02     INFO - TEST-UNEXPECTED-FAIL | /trusted-types/trusted-types-event-handlers.tentative.html | Event handler div.ontouchend should be blocked. - assert_throws_js: function "_ => element.setAttribute(name, "2+2")" did not throw
[task 2023-01-04T19:04:02.754Z] 19:04:02     INFO - @http://web-platform.test:8000/trusted-types/trusted-types-event-handlers.tentative.html:43:23
[task 2023-01-04T19:04:02.754Z] 19:04:02     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2591:25
[task 2023-01-04T19:04:02.754Z] 19:04:02     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-01-04T19:04:02.754Z] 19:04:02     INFO - @http://web-platform.test:8000/trusted-types/trusted-types-event-handlers.tentative.html:42:9
[task 2023-01-04T19:04:02.755Z] 19:04:02     INFO - 
Summary: Perma [Tier-2] /trusted-types/trusted-types-event-handlers.tentative.html | single tracking bug → Perma [Tier-2] /trusted-types/trusted-types-event-handlers.tentative.html | Event handler div.ontouchstart should be blocked.
Flags: needinfo?(james)
Regressed by: 1806971

Set release status flags based on info from the regressing bug 1806971

I think this was fixed in Bug 1808568

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(james)
Resolution: --- → WORKSFORME

It`s still failing on central

Flags: needinfo?(jmaher)

odd, the change is in there and from what I see it is the correct test which would be expected: FAIL:
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/trusted-types/trusted-types-event-handlers.tentative.html.ini#305

:jgraham, do you think the harness is not parsing this properly?

Flags: needinfo?(jmaher) → needinfo?(james)

https://hg.mozilla.org/mozilla-central/file/tip/testing/web-platform/meta/trusted-types/trusted-types-event-handlers.tentative.html.ini suggests these changes aren't in mozilla-central. Seems like they were removed in Bug 1808950. But the current in-progress sync will re-add them: https://hg.mozilla.org/try/diff/2e399199f228a5f14d04490e8555e29067e363ed/testing/web-platform/meta/trusted-types/trusted-types-event-handlers.tentative.html.ini. So I don't think the metadata parsing is going wrong, but something odd is happening.

It looks like the test is trying to query all the properties of a div element (for (name in div.__proto__)) and it only affects the touch attributes, so my guess is for some reason we're jumping between configurations where those properties are defined and ones where they aren't.

Flags: needinfo?(james)
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---

Set release status flags based on info from the regressing bug 1806971

Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.