1808615 - Make addTab default skipLoad to createLazyBrowser

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task)

Description

[Oriol Brufau [:Oriol]]

In https://phabricator.services.mozilla.com/D17084 I added support for using addTab to add a lazy tab. However, using createLazyBrowser: true is not enough, e.g. this just produces a blank tab:

gBrowser.addTrustedTab("http://example.com", {createLazyBrowser: true})

As a workaround, in adoptTab I used allowInheritPrincipal: true, since this works well:

gBrowser.addTrustedTab("http://example.com", {createLazyBrowser: true, allowInheritPrincipal: true})

https://phabricator.services.mozilla.com/D18742 tried to change that, since

allowInheritPrincipal has other implications that we should limit as much as possible to avoid unpleasant surprises from a security perspective

However, that patch was backed out because of unrelated reasons.

Using skipLoad: true instead of allowInheritPrincipal: true seems to work well too:

gBrowser.addTrustedTab("http://example.com", {createLazyBrowser: true, skipLoad: true})

So I think that skipLoad should just default to createLazyBrowser.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1808615 - Make addTab default skipLoad to createLazyBrowser. r?Gijs

And make callers rely on that instead of allowInheritPrincipal when
creating lazy tabs.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b67bd0dd255
Make addTab default skipLoad to createLazyBrowser. r=Gijs,extension-reviewers,nika,robwu

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures in browser/components/customizableui/test/browser_open_in_lazy_tab.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/708c665f54920af5bcf4aea2426e1f06a3b4bd9b

Push with failures

Failure log

TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_open_in_lazy_tab.js | Test timed out -

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af3799d0f7a5
Make addTab default skipLoad to createLazyBrowser. r=Gijs,extension-reviewers,nika,robwu

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/af3799d0f7a5