1808661 - Remove dead code from _setPositionalAttributes

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[Oriol Brufau [:Oriol]]

_setPositionalAttributes is called very frequently, and has some expensive code with no consumers. Just remove that.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1808661 - Remove beforeselected-visible and _beforeSelectedTab. r?Gijs

Comment 2

[Oriol Brufau [:Oriol]]

Attachment: Bug 1808661 - Remove first-visible-tab and _firstTab. r?Gijs

Depends on D166024

Comment 3

[Oriol Brufau [:Oriol]]

Attachment: Bug 1808661 - Remove last-visible-tab and _lastTab. r?Gijs

Depends on D166025

Comment 4

[Oriol Brufau [:Oriol]]

Attachment: Bug 1808661 - Remove before-multiselected and beforeMultiselected. r?Gijs

Depends on D166026

Comment 5

[Oriol Brufau [:Oriol]]

Attachment: Bug 1808661 - Remove beforehovered and afterhovered. r?Dao

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0c1ee751b7a
Remove beforeselected-visible and _beforeSelectedTab. r=Gijs,dao
https://hg.mozilla.org/integration/autoland/rev/b22c7589a7bb
Remove first-visible-tab and _firstTab. r=Gijs,dao
https://hg.mozilla.org/integration/autoland/rev/c2ad604be361
Remove last-visible-tab and _lastTab. r=Gijs,dao
https://hg.mozilla.org/integration/autoland/rev/607a282e25f5
Remove before-multiselected and beforeMultiselected. r=Gijs,dao
https://hg.mozilla.org/integration/autoland/rev/16871d37b859
Remove beforehovered and afterhovered. r=dao

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing browser-chrome failures in browser/base/content/test/tabs/browser_positional_attributes.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/5d7bb031124916505b1bd27772a1a0d62142800e

Push with failures

Failure log

INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_positional_attributes.js | tab #3 should have the visuallyselected attribute - Got false, expected true
[task 2023-01-06T20:10:58.013Z] 20:10:58     INFO - Stack trace:
[task 2023-01-06T20:10:58.013Z] 20:10:58     INFO - chrome://mochikit/content/browser-test.js:test_is:1477
[task 2023-01-06T20:10:58.013Z] 20:10:58     INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_positional_attributes.js:testAttrib:20
[task 2023-01-06T20:10:58.013Z] 20:10:58     INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_positional_attributes.js:test_pinning:51
[task 2023-01-06T20:10:58.013Z] 20:10:58     INFO - chrome://mochikit/content/browser-test.js:handleTask:1037
[task 2023-01-06T20:10:58.013Z] 20:10:58     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1109
[task 2023-01-06T20:10:58.013Z] 20:10:58     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-01-06T20:10:58.013Z] 20:10:58     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_positional_attributes.js | tab #0 should have the visuallyselected attribute - Got false, expected true

Comment 8

[Oriol Brufau [:Oriol]]

I missed that removing a subtest affected the following one.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9aaf8c0af51
Remove beforeselected-visible and _beforeSelectedTab. r=Gijs,dao
https://hg.mozilla.org/integration/autoland/rev/7b073cd0f4d7
Remove first-visible-tab and _firstTab. r=Gijs,dao
https://hg.mozilla.org/integration/autoland/rev/f7ba804ea8ec
Remove last-visible-tab and _lastTab. r=Gijs,dao
https://hg.mozilla.org/integration/autoland/rev/ef929be929e5
Remove before-multiselected and beforeMultiselected. r=Gijs,dao
https://hg.mozilla.org/integration/autoland/rev/1af752ee7a9d
Remove beforehovered and afterhovered. r=dao

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b9aaf8c0af51
https://hg.mozilla.org/mozilla-central/rev/7b073cd0f4d7
https://hg.mozilla.org/mozilla-central/rev/f7ba804ea8ec
https://hg.mozilla.org/mozilla-central/rev/ef929be929e5
https://hg.mozilla.org/mozilla-central/rev/1af752ee7a9d