1808685 - GetCurrentSerialEventTarget should return the nested event target when a sync loop is running

Status: NEW

(Core :: DOM: Workers, task, P3)

Description

[Jan Varga [:janv]]

We attempted to fix this in D163841 as part of bug 1803062, but it caused many regressions like bug 1806153, bug 1806205 and bug 1806530.
In the meantime, we discovered that we actually need to use the control event target instead of GetCurrentSerialEventTarget in FileSystemSyncAccessHandle::BeginClose.
So D163841 can be reverted for now and potential re-landing should be done as part of this new bug.

Comment 1

[Jan Varga [:janv]]

Actually, we don't have to revert entire patch, we only have to avoid setting the current serial event target.

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1808685 - Don't use SerialEventTargetGuard in workers code for now; r=#dom-worker-reviewers

Depends on D166047

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4208a0e0b9cd
Don't use SerialEventTargetGuard in workers code for now; r=dom-worker-reviewers,smaug

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4208a0e0b9cd

Comment 5

[Jan Varga [:janv]]

That was just a disabling patch.