Open Bug 1808685 Opened 3 months ago Updated 3 months ago

GetCurrentSerialEventTarget should return the nested event target when a sync loop is running

Categories

(Core :: DOM: Workers, task, P3)

Product:
Core
Component:
DOM: Workers
Type:
task

Tracking

()

Milestone:
110 Branch
Tracking Flags:
Tracking Status
firefox110 --- fixed

People

(Reporter: janv, Unassigned)

References

Details

Attachments

(1 file)

Bug 1808685 - Don't use SerialEventTargetGuard in workers code for now; r=#dom-worker-reviewers
48 bytes, text/x-phabricator-request
Details | Review

We attempted to fix this in D163841 as part of bug 1803062, but it caused many regressions like bug 1806153, bug 1806205 and bug 1806530.
In the meantime, we discovered that we actually need to use the control event target instead of GetCurrentSerialEventTarget in FileSystemSyncAccessHandle::BeginClose.
So D163841 can be reverted for now and potential re-landing should be done as part of this new bug.

Depends on: 1808687

Actually, we don't have to revert entire patch, we only have to avoid setting the current serial event target.

Assignee: nobody → jvarga
Status: NEW → ASSIGNED
Attachment #9310810 - Attachment description: Bug 1808685 - Don't use SerialEventTargetGuard in workers code for now; r=#dom-storage → Bug 1808685 - Don't use SerialEventTargetGuard in workers code for now; r=#dom-worker-reviewers
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4208a0e0b9cd
Don't use SerialEventTargetGuard in workers code for now; r=dom-worker-reviewers,smaug

https://hg.mozilla.org/mozilla-central/rev/4208a0e0b9cd

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox110: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch

That was just a disabling patch.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: jvarga → nobody
Status: REOPENED → NEW
You need to log in before you can comment on or make changes to this bug.