1808692 - SOCKS implementation does not support UDP

Status: UNCONFIRMED

(Core :: Networking: Proxy, defect, P2)

Description

[lin]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:108.0) Gecko/20100101 Firefox/108.0

Steps to reproduce:

1. Prepare a SOCKS5 proxy server

2. Open about:preferences in the browser and click "Network Settings"

3. Fill in "Manual proxy configuration", "SOCKS Host", "Port"

4. Select "Proxy DNS when using SOCKS v5"

5. Open a webrtc test page, for example https://ip.voidsec.com/

Actual results:

The "Web RTC:" item on the page, the relevant information is empty

Expected results:

The "Web RTC:" item on the page displays the address information of webrtc

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Networking' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Valentin Gosu [:valentin] (he/him) {{ FYI: OOO 14 June - 4 August }}]

Randell, could you take a look at this one?

Comment 3

[Pedro [:pedrov]]

I wonder if it's a limitation of wanting to use UDP for WebRTC, but not being capable of doing that over SOCKS5 possibly as a result of the lack of implementation.

It's definitely not a global setting problem breaking everything at least.
I use containers, and the ones with a proxy specified can't use WebRTC while the functionality remains working outside of those containers.

Comment 4

[Valentin Gosu [:valentin] (he/him) {{ FYI: OOO 14 June - 4 August }}]

Yes, I think WebRTC proxying doesn't work when a proxy is in use.
The SOCKSIOLayer does not have a method for sendto and recvfrom, so presumably it can't proxy UDP traffic.
This limitation is also present in (Chrome's SOCKS implementation](https://chromium.googlesource.com/chromium/src/+/HEAD/net/docs/proxy.md#socksv5-proxy-scheme).

Comment 5

[Giorgio Maone [:ma1]]

This seems the bug preventing us from fixing this Mullvad Browser issue: WebRTC leaks UDP traffic outside socks5 proxy .

If we set media.peerconnection.ice.proxy_only_if_behind_proxy to true we just break WebRTC.

Is there any hope for a fix or a work-around suggestion?

Thanks in advance!

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Looping in webrtc team

Comment 7

[Byron Campen [:bwc]]

Correct, we have not implemented UDP proxy support. Right now, if you want a proxy, you need to use TCP.

Comment 8

[BMO Automation]

Moving bug to Core/Networking: Proxy.

Comment 9

[BMO Automation]

Moving bug to Core/Networking: Proxy

Comment 11

[Konstantin]

Are you planning to add UDP support to SOCKS proxying?

Comment 12

[Manuel Bucher [:manuel]]

It is on Necko's roadmap, so we will get to it eventually. But currently there is no estimate on when we start working on this. We are definitely taking patches and would help out mentoring if anyone is interested in implementing it.

Comment 13

[Konstantin]

Thx.