180870 - Remove old shadowdb manual replication code

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P2)

Description

[Bradley Baetz (:bbaetz)]

Now that bug 124589 is in, we can pull out the old hacked up code for manual
replication.

Comment 1

[Bradley Baetz (:bbaetz)]

Attachment: fix

OK, this removes the support code for syncshadowdb.

The only issue is that people using a shadowdb who are upgrading will end up
failing because the host/port will be set to ''. Results would be incorrect in
any case, though, due to the lack of syncshadowdb, so I don't think we should
care about that.

This has been lightly tested locally, and I don't intend to commit this until
after bmo uses replication.

Comment 2

[Bradley Baetz (:bbaetz)]

The patch will have a small conflict in defparams.pl wrt a description change;
should be trival to manually fix for a review.

Comment 3

[Bradley Baetz (:bbaetz)]

Attachment: v2

Fixes cvs conflicts, and also removes the lcok code in post_bug, which isn't
needed since mysql handles auto_incrememnt replicaiton properly.

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 107325 [details] [diff] [review]
v2

This is basically jsut code removal, and should be trivial once replication is
tested on bmo

Comment 5

[Bradley Baetz (:bbaetz)]

Comment on attachment 107325 [details] [diff] [review]
v2

Note that removing the synshadowdb script is also part of this patch

Comment 6

[Joel Peshkin]

I'm confused about this patch.  It seems to be leaving some replication functions
in place.  How much is supposed to be going and how much is supposed to stay?

Comment 7

[Bradley Baetz (:bbaetz)]

Whats gone is the bit where we do the replicaiton (ie syncshadowdb) We still
support a separate database to work arround mysql's table-level locking, but w
enow require something else to handle moving data from one table to the other.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 107325 [details] [diff] [review]
v2

r=myk

Comment 9

[Bradley Baetz (:bbaetz)]

Checked in