Closed Bug 180870 Opened 18 years ago Closed 18 years ago

Remove old shadowdb manual replication code

Categories

(Bugzilla :: Bugzilla-General, defect, P2)

2.17.1
x86
Linux
defect

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: bbaetz, Assigned: bbaetz)

References

Details

Attachments

(1 file, 1 obsolete file)

Now that bug 124589 is in, we can pull out the old hacked up code for manual
replication.
Status: NEW → ASSIGNED
Priority: -- → P2
Summary: Remove old shadowdb manual replicaiton code → Remove old shadowdb manual replication code
Target Milestone: --- → Bugzilla 2.18
Attached patch fix (obsolete) — Splinter Review
OK, this removes the support code for syncshadowdb.

The only issue is that people using a shadowdb who are upgrading will end up
failing because the host/port will be set to ''. Results would be incorrect in
any case, though, due to the lack of syncshadowdb, so I don't think we should
care about that.

This has been lightly tested locally, and I don't intend to commit this until
after bmo uses replication.
Attachment #106775 - Flags: review?(myk)
The patch will have a small conflict in defparams.pl wrt a description change;
should be trival to manually fix for a review.
Blocks: 163290
Attached patch v2Splinter Review
Fixes cvs conflicts, and also removes the lcok code in post_bug, which isn't
needed since mysql handles auto_incrememnt replicaiton properly.
Attachment #106775 - Attachment is obsolete: true
Attachment #106775 - Flags: review?(myk)
Comment on attachment 107325 [details] [diff] [review]
v2

This is basically jsut code removal, and should be trivial once replication is
tested on bmo
Attachment #107325 - Flags: review?(myk)
Comment on attachment 107325 [details] [diff] [review]
v2

Note that removing the synshadowdb script is also part of this patch
Attachment #107325 - Flags: review?(bugreport)
I'm confused about this patch.  It seems to be leaving some replication functions
in place.  How much is supposed to be going and how much is supposed to stay?
Whats gone is the bit where we do the replicaiton (ie syncshadowdb) We still
support a separate database to work arround mysql's table-level locking, but w
enow require something else to handle moving data from one table to the other.
Comment on attachment 107325 [details] [diff] [review]
v2

r=myk
Attachment #107325 - Flags: review?(myk) → review+
Flags: approval+
Checked in
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Attachment #107325 - Flags: review?(bugreport)
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.