1808705 - Crash in [@ java.lang.RuntimeException: at org.webrtc.CameraCapturer.<init>]

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Byron Campen [:bwc]]

Crash report: https://crash-stats.mozilla.org/report/index/f5bcf3e0-24bb-40ed-9f9c-03e160230105

Java stack trace:

java.lang.RuntimeException
	at org.webrtc.CameraCapturer.<init>(CameraCapturer.java:106)
	at org.webrtc.Camera1Capturer.<init>(Camera1Capturer.java:6)
	at org.webrtc.Camera1Enumerator.createCapturer(Camera1Enumerator.java:5)
	at org.webrtc.videoengine.VideoCaptureAndroid.<init>(VideoCaptureAndroid.java:96)

This is our top crash right now.

Comment 1

[Byron Campen [:bwc]]

Looking at this and the related bugs, the line numbers in the stack seem to be pretty unreliable. It looks like this crash might be happening here, in a thread assertion:

https://searchfox.org/mozilla-central/rev/4ebfb48f7e82251145afa4a822f970931dd06c68/third_party/libwebrtc/sdk/android/src/java/org/webrtc/CameraCapturer.java#444

Comment 2

[John Lin [:jhlin][:jolin]]

The crash log java.lang.RuntimeException: No cameras attached. suggests that Android failed to enumerate cameras on the device. While this is not a normal situation (the devices in the crash reports do have cameras), the exception should be caught to prevent Gecko from crashing.

Comment 3

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1808705 - catch 'No cameras attached' exception.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:jhlin, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 5

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1808705 - test VideoCaptureAndroid with mock camera enumerator. r=pehrsons

Comment 6

[Byron Campen [:bwc]]

Is this bug stuck? This is our top crasher (besides bug 1808025) right now.

Comment 7

[John Lin [:jhlin][:jolin]]

Sorry, my bad. The fix is ready, but I failed to follow up on the test case. Will revise it and address the review comment ASAP.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb9a6fdf3e6c
catch 'No cameras attached' exception. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/eb9bd67b5b8f
test VideoCaptureAndroid with mock camera enumerator. r=pehrsons,geckoview-reviewers

Comment 9

[Cosmin Sabou [:CosminS]]

Backed out for gv-junit failures on VideoCaptureTest.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=f408182c4687f0490084c35cc766e637d0bdfd0f&selectedTaskRun=DpnFTK7mQuefzOKS32ia_g.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=449811749&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/85ad123faf67f92c548cbc665be1d739b0697b88

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6f8898d2583
catch 'No cameras attached' exception. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/c61f6c3b2e0e
test VideoCaptureAndroid with mock camera enumerator. r=pehrsons,geckoview-reviewers

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e6f8898d2583
https://hg.mozilla.org/mozilla-central/rev/c61f6c3b2e0e