1808721 - showTab and hideTab shouldn't invalidate cached _tabs

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task)

Description

[Oriol Brufau [:Oriol]]

showTab and hideTab call _invalidateCachedTabs:

    _invalidateCachedTabs() {
      this._tabs = null;
      this._visibleTabs = null;
    },

Of course _visibleTabs needs to be invalidated when a tab visibility changes, but I don't see the need to invalidate _tabs.

Recomputing gBrowser.tabs can be slow when there are thousands of tabs, so better to not invalidate the cache unnecessarily.

Probably not a big deal since I don't think showTab and hideTab are frequently used, but the improvement is trivial.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1808721 - Stop invalidating cached _tabs from showTab and hideTab. r?Gijs

Invalidating cached _visibleTabs should be enough.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7c21d63bd62
Stop invalidating cached _tabs from showTab and hideTab. r=dao

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b7c21d63bd62