Closed Bug 1808729 Opened 1 year ago Closed 1 year ago

Limit session store writes to once per hour when the user is idle

Categories

(Firefox :: Session Restore, defect)

defect

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: florian, Assigned: florian)

References

(Blocks 2 open bugs)

Details

(Keywords: perf:resource-use)

Attachments

(2 files)

Bug 1305950 tried to do this, but started treating the user as idle after 180'000s (50 hours), when according to the comment it meant to do it after 3 minutes: https://searchfox.org/mozilla-central/rev/f9f59140398bc4d04d840e8217c04e0d7eafafb9/browser/components/sessionstore/SessionSaver.jsm#373

This is because the nsIUserIdleService API takes times in seconds, rather than milliseconds.

Assignee: nobody → florian
Status: NEW → ASSIGNED
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a38da4f6de9
Limit session store writes to once per hour when the user is idle, r=dao.

Backed out for causing bc failures in browser/components/sessionstore/test/browser_not_collect_when_idle.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/edb547f53e73e3998268914bf3068a4ee4fe7825

Push with failures

Failure log

INFO - Buffered messages finished
[task 2023-01-09T14:15:23.544Z] 14:15:23     INFO - TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_not_collect_when_idle.js | Test timed out - 
[task 2023-01-09T14:15:23.544Z] 14:15:23     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-01-09T14:15:23.545Z] 14:15:23     INFO - TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_not_collect_when_idle.js | Uncaught exception received from previously timed out test - sessionstore-state-write-complete observer not removed before the end of test
[task 2023-01-09T14:15:23.547Z] 14:15:23     INFO - GECKO(1566) | MEMORY STAT | vsize 11714MB | residentFast 616MB | heapAllocated 273MB
Flags: needinfo?(florian)
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6ec3664e1f5
Limit session store writes to once per hour when the user is idle, r=dao.

Backed out for causing mochitests failures in browser_privatebrowsing_history_shift_click.js.

Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/136439e2444d
Limit session store writes to once per hour when the user is idle, r=dao.
https://hg.mozilla.org/integration/autoland/rev/3f6565dbb655
reset the user idle service before each browser-chrome mochitest, r=jmaher.
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Flags: needinfo?(florian)
You need to log in before you can comment on or make changes to this bug.