1808733 - Crash in [@ mozilla::layers::PersistentBufferProviderShared::IsAccelerated]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

89 crashes for Firefox version 109 and 110 on Windows.

Crash report: https://crash-stats.mozilla.org/report/index/a8d56064-8e98-4be9-bad7-78d230230103

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0  xul.dll  mozilla::layers::PersistentBufferProviderShared::IsAccelerated const  gfx/layers/PersistentBufferProvider.cpp:662
1  xul.dll  mozilla::dom::CanvasRenderingContext2D::BorrowTarget  dom/canvas/CanvasRenderingContext2D.cpp:1350
2  xul.dll  mozilla::dom::CanvasRenderingContext2D::EnsureTarget  dom/canvas/CanvasRenderingContext2D.cpp:1434
3  xul.dll  mozilla::dom::CanvasRenderingContext2D::UpdateWebRenderCanvasData  dom/canvas/CanvasRenderingContext2D.cpp:5719
4  xul.dll  nsHTMLCanvasFrame::UpdateWebRenderCanvasData  layout/generic/nsHTMLCanvasFrame.cpp:479
4  xul.dll  nsDisplayCanvas::CreateWebRenderCommands  layout/generic/nsHTMLCanvasFrame.cpp:148
5  xul.dll  mozilla::layers::WebRenderCommandBuilder::CreateWebRenderCommands  gfx/layers/wr/WebRenderCommandBuilder.cpp:1822
5  xul.dll  mozilla::layers::WebRenderCommandBuilder::CreateWebRenderCommandsFromDisplayList  gfx/layers/wr/WebRenderCommandBuilder.cpp:2088
6  xul.dll  mozilla::nsDisplayTransform::CreateWebRenderCommands  layout/painting/nsDisplayList.cpp:6727
7  xul.dll  mozilla::layers::WebRenderCommandBuilder::CreateWebRenderCommands  gfx/layers/wr/WebRenderCommandBuilder.cpp:1822

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1808733 - Check for null TextureData. r?aosmond

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Crash volume is high enough that we probably want to get this uplifted before we cut the RC next week.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74e70f651dca
Check for null TextureData. r=aosmond

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/74e70f651dca

Comment 5

[Lee Salzman [:lsalzman]]

Comment on attachment 9310884 [details]
Bug 1808733 - Check for null TextureData. r?aosmond

Beta/Release Uplift Approval Request

• User impact if declined: Crashes when using Canvas2D on Windows.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This just adds some straight-forward null pointer checks. It shouldn't break anything and will in all likelihood fix the crashes which seem to be null derefs at these places. Worst case scenario, it shouldn't break anything even if it does nothing. This will be easier to verify the fix once we uplift this to beta.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9310884 [details]
Bug 1808733 - Check for null TextureData. r?aosmond

Approved for 109.0rc1.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6d113e44ba05