1808771 - In permanent PBM with a tab pinned, Fx closes without confirmation

Status: NEW

(Firefox :: Tabbed Browser, defect)

Description

[Boomerang_Aide]

Steps to reproduce:

I still hope one day we can have a "warnOnQuit" setting that always, without conditions, prevent Firefox to quit when accidentally hitting the button at the top right or anything else, but knowing that's not how it work, I play by the rules by adding "warnOnClose" and having always 2 empty tabs open as a safety.
Recently, I realized this wasn't enough, and identified one specific reproducible bug that could cause the quit to happen:

Set the browser to "always run in privacy mode"
In about:config set browser.warnOnQuit to true
In about:config set browser.warnOnClose to true
Open a tab to have 2 of them
Experiment 1: try to press the X on the window to close
Pin 1 or both of the tabs
Experiment 2: try to press the X on the window to close

I think other conditions could prevent the confirmation to happen, but I wasn't able to identify them (and reproduce them).

Note: tested on Firefox 102 ESR

Actual results:

Experiment 1: Firefox should display a warning and not close unless confirmation is given
Experiment 2: Firefox close without warning or confirmation

Expected results:

When all conditions are reunited, Firefox should never close without giving a warning and requiring a confirmation

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Messaging System' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Shane Hughes [:aminomancer]]

So if I understand correctly, the problem is that in permanent private browsing mode, when all tabs are pinned, Firefox closes without a confirmation. Can you confirm that's basically the issue?

Comment 3

[Boomerang_Aide]

The broader issue is that Firefox can close without confirmation even when the options to prevent it are on, but the specific reproducible bug that I detailed is how you said: in a case when the warning would work most of the time, the tabs being pinned prevent the warning from happening.
Since it takes 2 tabs open to get the warning, only 1 being pinned is enough to trigger the bug.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.