1808784 - Cache gBrowser.tabContainer.allTabs instead of gBrowser.tabs

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task)

Description

[Oriol Brufau [:Oriol]]

gBrowser.tabs is cached:

    get tabs() {
      if (!this._tabs) {
        this._tabs = this.tabContainer.allTabs;
      }
      return this._tabs;
    },

However, some tabContainer code accesses allTabs directly, which is not cached.

It seems to me that gBrowser.tabContainer.allTabs should be cached, and gBrowser.tabs should just redirect to gBrowser.tabContainer.allTabs.

I haven't identified a case where this causes perf problems, but it's a trivial refactoring.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1808784 - Cache gBrowser.tabContainer.allTabs. r?Gijs

gBrowser.tabs was either redirecting to gBrowser.tabContainer.allTabs or
using the previously cached result. However, most tabContainer code uses
allTabs directly, which was not benefiting from the cache.

Therefore, this patch caches gBrowser.tabContainer.allTabs, and makes
gBrowser.tabs always redirect to it.

Also makes it consistent for gBrowser.tabContainer._getVisibleTabs() and
gBrowser.visibleTabs. In that case both the logic and the cache were in
gBrowser, and tabContainer was redirecting to that, except when gBrowser
hadn't been initialized.

So it's better to have both the logic and the cache in tabContainer.

Comment 2

[Oriol Brufau [:Oriol]]

Attachment: Bug 1808784 - Move tab invalidation methods to gBrowser.tabContainer. r?Gijs

D166962 is moving the cache into gBrowser.tabContainer, so the methods
for invalidating it should also be there.

Depends on D166962

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97231aeb0e5b
Cache gBrowser.tabContainer.allTabs. r=Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f64ced636854
Move tab invalidation methods to gBrowser.tabContainer. r=Gijs

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/97231aeb0e5b

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f64ced636854