1808882 - Horizontal menu separators are not the same color when using the generated themes as when using privileged themes

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P5)

Description

[Alex Cornestean]

Attachment: 2023-01-06_11h20_43.png

Description:
Horizontal menu separators are gray when using generated themes as opposed to colored in the theme accent color when using privileged themes.

Affected areas:

• Hamburger menu and sub-menus
• Unified Extensions Button panel
• “List all tabs” button panel (far right downward facing arrow button)
• “Site information” panel (lock icon left of URL or “Nightly/Firefox” box left of URL when on privileged pages such as about:addons)
• “Protections” panel (shield icon left of URL)
• Downloads panel

NOTE: Panel outline color is consistent between the generated and privileged themes.

Steps to reproduce:

1. Prepare two instances of Nightly with new profiles
2. Access about:config on both and set extensions.experiments.enable to true
3. Restart the browsers to apply the above pref
4. Load a pair of the same generated and privileged theme in the browsers via about:debugging
5. Access the above mentioned affected areas and observe the difference between the horizontal menu separator colors when using the generated/privileged themes

Actual:
Generated themes horizontal menu separators are gray and don’t use the theme accent color as in the case of the privileged themes

Expected:
Horizontal menu separators for the generated themes should be the same color as for the privileged themes.

Comment 1

[Alex Cornestean]

Update:
Bookmarks and Permissions panel are also affected by the issue.

Comment 2

[Alex Cornestean]

The affected generated themes are:

independent-voices – activist-balanced-colorway
independent-voices – activist-bold-colorway
independent-voices – activist-soft-colorway
independent-voices – dreamer-balanced-colorway
independent-voices – dreamer-bold-colorway
independent-voices – dreamer-soft-colorway
independent-voices – expressionist-balanced-colorway
independent-voices – expressionist-bold-colorway
independent-voices – expressionist-soft-colorway
independent-voices – innovator-balanced-colorway
independent-voices – innovator-bold-colorway
independent-voices – innovator-soft-colorway
independent-voices – playmaker-balanced-colorway
independent-voices – playmaker-bold-colorway
independent-voices – playmaker-soft-colorway
independent-voices – visionary-balanced-colorway
independent-voices – visionary-bold-colorway
independent-voices – visionary-soft-colorway
life-in-color—abstract-balanced-colorway
life-in-color—abstract-bold-colorway
life-in-color—abstract-soft-colorway
life-in-color—cheers-balanced-colorway
life-in-color—cheers-bold-colorway
life-in-color—cheers-soft-colorway
life-in-color—elemental-balanced-colorway
life-in-color—elemental-bold-colorway
life-in-color—foto-balanced-colorway
life-in-color—foto-bold-colorway
life-in-color—foto-soft-colorway
life-in-color—graffiti-balanced-colorway
life-in-color—graffiti-bold-colorway
life-in-color—graffiti-soft-colorway
life-in-color—lush-balanced-colorway
life-in-color—lush-bold-colorway
life-in-color—lush-soft-colorway
true-colors—2022blue-colorway
true-colors—2022green-colorway
true-colors—2022orange-colorway
true-colors—2022purple-colorway
true-colors—2022red-colorway
true-colors—2022yellow-colorway

Not affected:
life-in-color—elemental-soft-colorway (horizontal separators appear to be the same color on both privileged and generated themes)

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1808882 - Improve panel separator contrast. r=sfoster

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b67305108ea9
Improve panel separator contrast. r=Itiel

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b67305108ea9

Comment 7

[Alex Cornestean]

Verified as Fixed on the latest Nightly (111.0a1/20230124213422). Tested on Windows 10 x64 and Ubuntu 16.04 LTS.

I compared several newly generated themes (v2.1) in regards to the color of the horizontal panel separators between the latest Beta Developer Edition (110.0b5/20230124185837) which does not include the fix and the latest Nightly, which includes the fix.

The horizontal separators are indeed more visible on Nightly as opposed to Beta due to increased contrast, confirming the fix.

For more details, see the attached screenshots.

Tested with the following themes:

• independent-voices – activist-balanced-colorway
• independent-voices – innovator-bold-colorway
• life-in-color—graffiti-soft-colorway
• independent-voices – playmaker-bold-colorway

Note that Beta is on the left and the Nightly is on the right in the attached screenshots.

Comment 8

[Alex Cornestean]

Attachment: 2023-01-25_09h57_39.png

Comment 9

[Alex Cornestean]

Attachment: 2023-01-25_09h59_52.png

Comment 10

[Alex Cornestean]

Attachment: 2023-01-25_10h05_38.png

Comment 11

[Alex Cornestean]

Attachment: 2023-01-25_10h08_01.png