1808958 - Intermittent TV browser/components/urlbar/tests/quicksuggest/browser/browser_telemetry_weather.js | Couldn't get a selectable non-quick-suggest row with a URL, stopping impression-only test - false == true - JS frame

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=401608778&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/GUvjTBdCQTGswtcu9DxGBQ/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/GUvjTBdCQTGswtcu9DxGBQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2023-01-06T17:41:54.171Z] 17:41:54     INFO - TEST-PASS | browser/components/urlbar/tests/quicksuggest/browser/browser_telemetry_weather.js | The quick suggest row should represent the expected suggestion - "http://example.com/weather" == "http://example.com/weather" - 
[task 2023-01-06T17:41:54.172Z] 17:41:54     INFO - TEST-PASS | browser/components/urlbar/tests/quicksuggest/browser/browser_telemetry_weather.js | No other row should be a quick suggest: index = 1 - "UrlbarProviderTopSites" != "UrlbarProviderQuickSuggest" - 
[task 2023-01-06T17:41:54.172Z] 17:41:54     INFO - TEST-PASS | browser/components/urlbar/tests/quicksuggest/browser/browser_telemetry_weather.js | No other row should be a quick suggest: index = 2 - "UrlbarProviderTopSites" != "UrlbarProviderQuickSuggest" - 
[task 2023-01-06T17:41:54.173Z] 17:41:54     INFO - Buffered messages finished
[task 2023-01-06T17:41:54.173Z] 17:41:54     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/quicksuggest/browser/browser_telemetry_weather.js | Couldn't get a selectable non-quick-suggest row with a URL, stopping impression-only test - false == true - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/quicksuggest/browser/head.js :: doImpressionOnlyTest :: line 339
[task 2023-01-06T17:41:54.173Z] 17:41:54     INFO - Stack trace:
[task 2023-01-06T17:41:54.173Z] 17:41:54     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/quicksuggest/browser/head.js:doImpressionOnlyTest:339
[task 2023-01-06T17:41:54.174Z] 17:41:54     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-01-06T17:41:54.174Z] 17:41:54     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/quicksuggest/browser/browser_telemetry_weather.js | Impression test didn't complete successfully, stopping telemetry test - false == true - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/quicksuggest/browser/head.js :: doTelemetryTest :: line 179
[task 2023-01-06T17:41:54.174Z] 17:41:54     INFO - Stack trace:
[task 2023-01-06T17:41:54.175Z] 17:41:54     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/quicksuggest/browser/head.js:doTelemetryTest:179
[task 2023-01-06T17:41:54.175Z] 17:41:54     INFO - Leaving test bound 
[task 2023-01-06T17:41:54.751Z] 17:41:54     INFO - GECKO(1519) | MEMORY STAT | vsize 16066MB | residentFast 320MB | heapAllocated 153MB
[task 2023-01-06T17:41:54.752Z] 17:41:54     INFO - TEST-OK | browser/components/urlbar/tests/quicksuggest/browser/browser_telemetry_weather.js | took 2130ms
[task 2023-01-06T17:41:54.799Z] 17:41:54     INFO - checking window state
[task 2023-01-06T17:41:54.952Z] 17:41:54     INFO - GECKO(1519) | Completed ShutdownLeaks collections in process 1519
[task 2023-01-06T17:41:54.952Z] 17:41:54     INFO - TEST-START | Shutdown

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:adw, since you are the author of the regressor, bug 1804536, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1804536

Comment 3

[Intermittent Failures Robot]

1 failures in 2607 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1808958&startday=2023-01-02&endday=2023-01-08&tree=all

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1804536

Comment 5

[Drew Willcoxon :adw]

This failure happened back when the weather suggestion was zero prefix, i.e., shown in the top-sites view when clicking the urlbar without a search string. It hasn't happened since we modified that behavior so it's shown for specific search strings, and it hasn't happened in months, so I think we can close this.

I would guess it had something to do with the test updating the top sites, which is async and for some reason has always been unreliable. The failure screenshot indeed seems to show there are no top sites in the view.