1808975 - HTTP error 511 Network Authentication Required is not detected as a captive portal

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Asbjørn Sloth Tønnesen [:a5n]]

Steps to reproduce:

Be on a network with a captive portal, that is intercepting all HTTP requests, and forging replies with HTTP status 511 Network Authentication Required as per RFC 6585.

Actual results:

The captive portal detection is not detecting the portal.

The code is treating any HTTP status other than 200 and 300-399 as
that everything is fine, and something must be up with the canonical URL,
so that a 503 error doesn't trigger the captive portal detection.

Expected results:

The captive portal should have been detected, as it was clearly signaled using the
method specified in RFC 6585.

Comment 1

[Asbjørn Sloth Tønnesen [:a5n]]

patch is incoming; once mercurial is done syncing

Comment 2

[Asbjørn Sloth Tønnesen [:a5n]]

Attachment: Bug 1808975 - Detect captive portal on HTTP status 511 Network Authentication Required. r=#necko,valentin

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:a5n, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 4

[Valentin Gosu [:valentin] (he/him)]

I triggered the landing, and filed bug 1812291 for followup work.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/baaf9d43798e
Detect captive portal on HTTP status 511 Network Authentication Required. r=valentin,necko-reviewers

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/baaf9d43798e