Closed Bug 1808975 Opened 2 years ago Closed 1 year ago

HTTP error 511 Network Authentication Required is not detected as a captive portal

Categories

(Core :: Networking, defect, P2)

defect

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: a5n, Assigned: a5n)

References

(Blocks 2 open bugs, )

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Steps to reproduce:

Be on a network with a captive portal, that is intercepting all HTTP requests, and forging replies with HTTP status 511 Network Authentication Required as per RFC 6585.

Actual results:

The captive portal detection is not detecting the portal.

The code is treating any HTTP status other than 200 and 300-399 as
that everything is fine, and something must be up with the canonical URL,
so that a 503 error doesn't trigger the captive portal detection.

Expected results:

The captive portal should have been detected, as it was clearly signaled using the
method specified in RFC 6585.

patch is incoming; once mercurial is done syncing

OS: Unspecified → All
Hardware: Unspecified → All
Assignee: nobody → mozilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9311151 - Attachment description: Bug 1808975 - Detect captive portal on HTTP status 511 Network Authentication Required. r=valentin → Bug 1808975 - Detect captive portal on HTTP status 511 Network Authentication Required. r=#necko,valentin
Severity: -- → S3
Priority: -- → P2
Whiteboard: [necko-triaged]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:a5n, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(valentin.gosu)
Flags: needinfo?(mozilla)

I triggered the landing, and filed bug 1812291 for followup work.

Flags: needinfo?(valentin.gosu)
Flags: needinfo?(mozilla)
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/baaf9d43798e
Detect captive portal on HTTP status 511 Network Authentication Required. r=valentin,necko-reviewers
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: