1808990 - Should drop commented out reference to editor-error.png which has never existed from source-editor.css

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[:Gijs (out for now; he/him)]

https://searchfox.org/mozilla-central/rev/57e03cb91c5b4ea5975c53f939fdd38819a6ec9d/devtools/client/debugger/new/src/utils/editor/source-editor.css#31 references an image that AFAICT has never existed - the commit adding this line ( https://hg.mozilla.org/mozilla-central/rev/869f7e9a19c31149b9a95db5b0101179e34d940b from bug 1518262) does a lot of stuff but doesn't seem to add this image. I ran into this in bug 1724718 because it makes the browser crash when trying to load files that do not exist, and the browser_all_files_referenced.js test (which, to be clear, does the opposite, and tries to work out if all the files we ship are actually needed) tries to load the image.

Given that it's been 4 years and none of the original authors are around, I think the reference can just be removed. I'll separately look into not making the test so eager to load these files, I guess...

Comment 1

[:Gijs (out for now; he/him)]

Attachment: Bug 1808990 - remove background-image CSS for .CodeMirror .error which is a no-op, r?bomsy,jdescottes

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1518262

Comment 3

[:Gijs (out for now; he/him)]

No user impact so wontfix all the earlier versions...

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

This bug has the keyword regression, so its type should be defect.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4019362b447a
remove background-image CSS for .CodeMirror .error which is a no-op, r=jdescottes

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4019362b447a