1809045 - [Inactive CSS] Several properties are incorrectly marked as not applying to :visited

Status: ASSIGNED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Oriol Brufau [:Oriol]]

https://searchfox.org/mozilla-central/rev/0947c440956c648b853cf79a4737b282396abf09/devtools/server/actors/utils/inactive-property-helper.js#22-47

const VISITED_INVALID_PROPERTIES = allCssPropertiesExcept([
  "all",
  "color",
  "background",
  "background-color",
  "border",
  "border-color",
  "border-bottom-color",
  "border-left-color",
  "border-right-color",
  "border-top-color",
  "border-block",
  "border-block-color",
  "border-block-start-color",
  "border-block-end-color",
  "border-inline",
  "border-inline-color",
  "border-inline-start-color",
  "border-inline-end-color",
  "column-rule",
  "column-rule-color",
  "outline",
  "outline-color",
  "text-decoration-color",
  "text-emphasis-color",
]);

This list is lacking some longhands (see https://searchfox.org/mozilla-central/rev/0947c440956c648b853cf79a4737b282396abf09/servo/components/style/properties/properties.mako.rs#944-965):

  "-webkit-text-fill-color",
  "-webkit-text-stroke-color",
  "caret-color",
  "fill",
  "stroke",

It's also lacking some shorthands:

  "-webkit-text-stroke",
  "border-block-start",
  "border-block-end",
  "border-inline-start",
  "border-inline-end",
  "border-top",
  "border-right",
  "border-bottom",
  "border-left",
  "text-decoration",
  "text-emphasis-color",

And some aliases:

  "-moz-border-start",
  "-moz-border-start-color",
  "-moz-border-end",
  "-moz-border-end-color",

It would be good if shorthands and aliases were automatically handled from the longhands (bug 1608993), and the longhands were obtained from servo.

Comment 1

[Julian Descottes [:jdescottes]]

Thanks for the report Oriol, do you want to take this bug by any chance?

Comment 2

[Oriol Brufau [:Oriol]]

I won't have time to write a proper solution that generates the list automatically.

Comment 3

[Sebastian Zartner [:sebo]]

Attachment: Bug 1809045 - [devtools] Correctly handle all properties allowed in :visited in inactive CSS. r=#devtools-reviewers.

All properties missing from the whitelist for styles allowed for visited links were added manually.

An automatic generation of the list of allowed properties (or at least of shorthands and aliases) is covered by bug 1608993.

Comment 4

[Sebastian Zartner [:sebo]]

I've simply added the missing properties to the list, so they are not incorrectly marked as invalid anymore.

The proper solution, which generates the list automatically, should be done in bug 1608993, maybe the Servo part for the longhands there, too, or in a new bug.

Sebastian

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:sebo, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Oops, I think sebo was waiting for an answer on Phabricator. I replied there