1809051 - Browser.getVersion should return the current and not a hardcoded JavaScript version

Status: RESOLVED FIXED

(Remote Protocol :: CDP, defect)

Description

[Oliver Medhurst [:canadahonk]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36

Steps to reproduce:

When using CDP with --remote-debugging-port, Browser.getVersion reports jsEngine "1.8.5", a very (~11 year old) SpiderMonkey version which is hardcoded here: https://hg.mozilla.org/mozilla-central/file/tip/remote/cdp/domains/parent/Browser.sys.mjs#l22

Actual results:

jsEngine reports "1.8.5".

Expected results:

It should report the actual SpiderMonkey/JS engine version in use.

Comment 1

[Rares Doghi, Desktop QA]

I think this could be related to Bug 1549421.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thank you for the report Rares! Would you actually be interested to get this fixed? You already had a good start with finding the appropriate code, so adding a fix and a test shouldn't be that hard for you. I'm happy to help with any upcoming question.

Comment 3

[Rares Doghi, Desktop QA]

I think Comment 2 was meant for @CanadaHonk, he was the one that found the code and added the report.

Comment 4

[Oliver Medhurst [:canadahonk]]

I'm interested in getting it fixed but not sure how to start. If there's any relevant docs or code for getting the SpiderMonkey version in use and adding a test, please send it.

Comment 5

[Oliver Medhurst [:canadahonk]]

Is there any chat (Matrix/IRC/etc) for discussing Firefox's CDP implementation?

Comment 6

[Oliver Medhurst [:canadahonk]]

Attachment: Bug 1809051 - [cdp] Browser.getVersion: compute jsVersion and add tests

Compute jsVersion using Firefox version instead of using a hardcoded
value. Also added relevant tests where existing version checks are.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The needinfo is no longer needed given that we discussed it on Element yesterday and I can see a patch uploaded. That's great! Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64caad7bc3bc
[cdp] Browser.getVersion: compute jsVersion and add tests r=webdriver-reviewers,whimboo

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/64caad7bc3bc