1809080 - Pinch-to-zoom in pdf viewer doesn't work anymore when using trackpad on Mac

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Calixte Denizet (:calixte)]

In Nightly, pinching on the MacBook trackpad leads to zoom all the window content (pdf.js toolbar included) when it must only zooms the pages.
In using mozregression, I got:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=db51149fe9596f05600937729cb381b9a3ac390b&tochange=46dae1c56dade459258373ddfed526da69c68c49

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1781960

:cpeterson, since you are the author of the regressor, bug 1781960, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Calixte Denizet (:calixte)]

Because of the mentioned patch, the getter here doesn't return the same value as before:
https://searchfox.org/mozilla-central/rev/d62c4c4d5547064487006a1506287da394b64724/toolkit/components/pdfjs/content/PdfStreamConverter.jsm#386
and consequently we don't catch the wheel events anymore:
https://github.com/mozilla/pdf.js/blob/067d3b70aa46e1b2a3dff768c36ff5ba670407f2/web/app.js#L2631-L2641
So we need have a way to guess that ctrl+wheel is coming from a pinch.

Comment 3

[Calixte Denizet (:calixte)]

Attachment: pr 15907: Fix pinch-to-zoom on a macbook trackpad (bug 1809080)

Comment 4

[Calixte Denizet (:calixte)]

Attachment: Bug 1809080 - Pinch-to-zoom in pdf viewer when using the trackpad on Mac r=#pdfjs-reviewers,RyanVM

Comment 5

[Calixte Denizet (:calixte)]

Comment on attachment 9311569 [details]
Bug 1809080 - Pinch-to-zoom in pdf viewer when using the trackpad on Mac r=#pdfjs-reviewers,RyanVM

Beta/Release Uplift Approval Request

• User impact if declined: Mac users who are zooming a pdf in using pinch-to-zoom on a trackpad will be disappointed.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - Open a pdf on mac

• pinch in using the trackpad
• only the pdf must be zoomed and not the toolbar

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only few lines, easy to test and pdf.js is self-contained.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9311569 [details]
Bug 1809080 - Pinch-to-zoom in pdf viewer when using the trackpad on Mac r=#pdfjs-reviewers,RyanVM

Approved for 109.0rc2, thanks.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/ea0c9f5c9b90

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 110.0a1 (2023-01-08) on macOS 11.5. PDF toolbar is also zoomed when using pinch to zoom on a PDF.
The issue is verified fixed with Firefox 110.0a1 (2022-01-12) and Firefox 109.0RC2 (20230112150232) on macOS 10.15, 11.5, and 12. PDF toolbar is no longer zoomed in and the PDF can be successfully zoomed out when using pinch to zoom on a PDF while using a trackpad.