1809124 - Simplify custom formatters actor implementation

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Alexandre Poirot [:ochameau]]

We could:

• lazy load this code in order to only load the formatter's code only if this feature is enabled
• move this code to a dedicated module as this is quite different from the rest of ObjectActor and is quite complex logic
• Factorize some code related to error logging
• Early return to reduce function nesting size
• By doing early return we may more consistantly process error first

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1809124 - [devtools] Move server side custom formatter logic to a dedicated module.

This help lazy load this significant code only if this feature is used.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1809124 - [devtools] Simplify the implementation of custom formatter actor.

• Use FormatterError exception to factorize the code to log formatter errors and ignore them
• Use one seperate function to process a single formatter to simplify the loop comprehension
• Use early return in both function to reduce the nesting of functions,
  and also process error first. This helps processFormatterForHeader process all errors first.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7af2fb02b518
[devtools] Move server side custom formatter logic to a dedicated module. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/c109c45212af
[devtools] Simplify the implementation of custom formatter actor. r=nchevobbe

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/7af2fb02b518
https://hg.mozilla.org/mozilla-central/rev/c109c45212af