1809179 - [wpt-sync] Sync PR 37810 - Refactor nested-navigations resource-timing flow

Status: RESOLVED FIXED

(Core :: DOM: Performance, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 37810 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37810
Details from upstream follow.

Noam Rosenthal <[e-mail]> wrote:

Refactor nested-navigations resource-timing flow

This changes how frames, iframes & objects decide how to report
their navigations as resource timing entries to their parent:

• Any frame-initiated navigation (e.g. iframe.src change) is
  reported as an entry. This complies with current spec.
• For nested navigations that fail Timing-Allow-Origin, we don't
  report the normal responseEnd - instead we report the load event
  time as the responseEnd, to prevent leakage of navigation-related
  cross-origin information
  (see https://github.com/w3c/resource-timing/issues/340)

This incidentally fixes other existing issues with nested navigations
and resource timing, such as flaky tests and inconsistencies regarding
restored iframes.

Bug: 1404695
Bug: 1348080
Bug: 1290721
Bug: 1380078
Bug: 1378015
Bug: 957181

Spec changes: https://github.com/whatwg/html/pull/8643
https://github.com/whatwg/fetch/pull/1579

Change-Id: I010b026788193cc77a7de3f3d75304602f41fcd5
Reviewed-on: https://chromium-review.googlesource.com/4145963
WPT-Export-Revision: bc9e0fe5fbc1962a2d5c8f1e122d2e2fca0fe75c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d44ce8d985b11ba350b240faee28404932719ea

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS : 19
FAIL : 2
TIMEOUT: 4
ERROR : 4

Chrome

OK : 2
PASS : 1
FAIL : 20
TIMEOUT: 4
ERROR : 4

Safari

OK : 2
PASS : 1
FAIL : 20
TIMEOUT: 4
ERROR : 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /resource-timing/nested-nav-fallback-timing.html [wpt.fyi]
  • Cross-origin TAO-fail IFrame entries should report window load time: FAIL (Chrome: FAIL, Safari: FAIL)
  • Cross-origin TAO-fail object entries should report window load time: FAIL (Chrome: FAIL, Safari: FAIL)
• /performance-timeline/tentative/include-frames-from-child-cross-origin-grandchild.sub.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
  • GetEntries of a Cross-Origin child frame with one Cross-Origin grandchild frame: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
• /performance-timeline/tentative/include-frames-from-child-same-origin-grandchild.sub.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
  • GetEntries of a Cross-Origin child frame with one Same-Origin grandchild frame: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
• /performance-timeline/tentative/include-frames-one-cross-origin-child-one-same-origin-grandchild.sub.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
  • GetEntries of a parent Frame with one Cross-Origin child and one Same-Origin grandchild: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
• /performance-timeline/tentative/include-frames-one-same-origin-child-one-same-origin-grandchild.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
  • GetEntries of a parent Frame with one Same-Origin child and one Same-Origin grandchild: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc12b69989f9
[wpt PR 37810] - Refactor nested-navigations resource-timing flow, a=testonly
https://hg.mozilla.org/integration/autoland/rev/ec51f6e1c7e5
[wpt PR 37810] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/cc12b69989f9
https://hg.mozilla.org/mozilla-central/rev/ec51f6e1c7e5