`moz-phab uplift --train` should take a shortname instead of callsign
Categories
(Conduit :: moz-phab, enhancement)
Tracking
(Not tracked)
People
(Reporter: sheehan, Assigned: sheehan)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We currently use the callsign to indicate which repo is used for uplift. We should make moz-phab
take the repo shortname instead as it is more readable due to callsigns being limited to characters, therefore esr91
is instead ESRNINEONE
. It would also align with what we use in the Lando web UI.
Assignee | ||
Comment 1•1 year ago
|
||
The current implementation of the train
parameter in moz-phab
uses
the repo callsign to specify the uplift target. The shortname
is
what the web UI uses and is the nicer name value we usually refer
to repos with.
Rename get_repository
to get_repository_by_callsign
to clarify
the input parameter and add a get_repository_by_shortname
function.
Update list_trains
to print the shortnames of the uplift repos instead
of the callsign. Then update map_train_arg_to_repo
to use the
shortname to find the repo information on Phabricator and have the
callsign set from the returned information instead of from
args.train
directly.
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Description
•