Closed
Bug 1809330
Opened 2 years ago
Closed 2 years ago
The MigrationWizard should be dismissable by clicking on a "Cancel" button when it is embedded in a dialog
Categories
(Firefox :: Migration, task)
Firefox
Migration
Tracking
()
RESOLVED
FIXED
111 Branch
Tracking | Status | |
---|---|---|
firefox111 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The MigrationWizard can be embedded in a dialog (either a stand-alone dialog window, or a TabDialogBox), or on its own in a privileged about: page.
In the former case, we want to make it possible to have "Cancel" buttons that will close the dialog.
This bug is for adding a "dialog-mode" attribute to the MigrationWizard that can be used to determine whether or not to show dialog-closing "Cancel" buttons, and then to respond appropriately within the migration-dialog.html document.
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → mconley
Assignee | ||
Comment 1•2 years ago
|
||
Depends on D165090
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57167994f026
Allow the MigrationWizard to close dialogs that it is embedded in. r=niklas
Comment 3•2 years ago
|
||
Backed out for causing failures on browser_dialog_cancel_close.js
- backout: https://hg.mozilla.org/integration/autoland/rev/4c3a6ff0488d28edc0d080b93682c156a24526d6
- push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=57167994f0267ab208e6920d906fdf89328f34f9
- tier 1 failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=GuaxgEN3SXyRGxJbpiOlQA.0&revision=97fc9f3f9d3900213938afb48980e0a1fec9f4ee&searchStr=browser-chrome
- failure log: https://treeherder.mozilla.org/logviewer?job_id=402369775&repo=autoland&lineNumber=5210
[task 2023-01-14T01:44:39.879Z] 01:44:39 INFO - TEST-PASS | browser/components/migration/tests/browser/browser_dialog_cancel_close.js | Dialog manager has a dialog. - 1 == 1 -
[task 2023-01-14T01:44:39.881Z] 01:44:39 INFO - Waiting for dialogs to open.
[task 2023-01-14T01:44:39.881Z] 01:44:39 INFO - Console message: [JavaScript Warning: "Unknown category for SetEventRecordingEnabled: page_load"]
[task 2023-01-14T01:44:39.883Z] 01:44:39 INFO - Console message: [JavaScript Warning: "Unknown category for SetEventRecordingEnabled: page_load"]
[task 2023-01-14T01:44:39.883Z] 01:44:39 INFO - Buffered messages logged at 01:43:55
[task 2023-01-14T01:44:39.887Z] 01:44:39 INFO - Console message: [JavaScript Error: "Error: Can't find profile directory." {file: "resource://gre/modules/XULStore.jsm" line: 58}]
[task 2023-01-14T01:44:39.888Z] 01:44:39 INFO - load@resource://gre/modules/XULStore.jsm:58:15
[task 2023-01-14T01:44:39.890Z] 01:44:39 INFO - XULStore@resource://gre/modules/XULStore.jsm:17:10
[task 2023-01-14T01:44:39.890Z] 01:44:39 INFO -
[task 2023-01-14T01:44:39.891Z] 01:44:39 INFO - Buffered messages finished
[task 2023-01-14T01:44:39.892Z] 01:44:39 INFO - TEST-UNEXPECTED-FAIL | browser/components/migration/tests/browser/browser_dialog_cancel_close.js | Test timed out -
[task 2023-01-14T01:44:39.894Z] 01:44:39 INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-01-14T01:44:39.895Z] 01:44:39 INFO - TEST-UNEXPECTED-FAIL | browser/components/migration/tests/browser/browser_dialog_cancel_close.js | Uncaught exception received from previously timed out test - MigrationWizard:Ready listener not removed before the end of test
[task 2023-01-14T01:44:39.896Z] 01:44:39 INFO - Entering test bound test_cancel_close
[task 2023-01-14T01:44:39.896Z] 01:44:39 INFO - TEST-PASS | browser/components/migration/tests/browser/browser_dialog_cancel_close.js | Window was closed. - true == true -
Updated•2 years ago
|
Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1987a6cc967c
Allow the MigrationWizard to close dialogs that it is embedded in. r=niklas
Comment 5•2 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox111:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Assignee | ||
Updated•2 years ago
|
Flags: needinfo?(mconley)
You need to log in
before you can comment on or make changes to this bug.
Description
•