Closed Bug 1809330 Opened 23 days ago Closed 16 days ago

The MigrationWizard should be dismissable by clicking on a "Cancel" button when it is embedded in a dialog

Categories

(Firefox :: Migration, task)

task

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The MigrationWizard can be embedded in a dialog (either a stand-alone dialog window, or a TabDialogBox), or on its own in a privileged about: page.

In the former case, we want to make it possible to have "Cancel" buttons that will close the dialog.

This bug is for adding a "dialog-mode" attribute to the MigrationWizard that can be used to determine whether or not to show dialog-closing "Cancel" buttons, and then to respond appropriately within the migration-dialog.html document.

Assignee: nobody → mconley
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57167994f026
Allow the MigrationWizard to close dialogs that it is embedded in. r=niklas
Regressions: 1810232

Backed out for causing failures on browser_dialog_cancel_close.js

[task 2023-01-14T01:44:39.879Z] 01:44:39     INFO - TEST-PASS | browser/components/migration/tests/browser/browser_dialog_cancel_close.js | Dialog manager has a dialog. - 1 == 1 - 
[task 2023-01-14T01:44:39.881Z] 01:44:39     INFO - Waiting for dialogs to open.
[task 2023-01-14T01:44:39.881Z] 01:44:39     INFO - Console message: [JavaScript Warning: "Unknown category for SetEventRecordingEnabled: page_load"]
[task 2023-01-14T01:44:39.883Z] 01:44:39     INFO - Console message: [JavaScript Warning: "Unknown category for SetEventRecordingEnabled: page_load"]
[task 2023-01-14T01:44:39.883Z] 01:44:39     INFO - Buffered messages logged at 01:43:55
[task 2023-01-14T01:44:39.887Z] 01:44:39     INFO - Console message: [JavaScript Error: "Error: Can't find profile directory." {file: "resource://gre/modules/XULStore.jsm" line: 58}]
[task 2023-01-14T01:44:39.888Z] 01:44:39     INFO - load@resource://gre/modules/XULStore.jsm:58:15
[task 2023-01-14T01:44:39.890Z] 01:44:39     INFO - XULStore@resource://gre/modules/XULStore.jsm:17:10
[task 2023-01-14T01:44:39.890Z] 01:44:39     INFO - 
[task 2023-01-14T01:44:39.891Z] 01:44:39     INFO - Buffered messages finished
[task 2023-01-14T01:44:39.892Z] 01:44:39     INFO - TEST-UNEXPECTED-FAIL | browser/components/migration/tests/browser/browser_dialog_cancel_close.js | Test timed out - 
[task 2023-01-14T01:44:39.894Z] 01:44:39     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-01-14T01:44:39.895Z] 01:44:39     INFO - TEST-UNEXPECTED-FAIL | browser/components/migration/tests/browser/browser_dialog_cancel_close.js | Uncaught exception received from previously timed out test - MigrationWizard:Ready listener not removed before the end of test
[task 2023-01-14T01:44:39.896Z] 01:44:39     INFO - Entering test bound test_cancel_close
[task 2023-01-14T01:44:39.896Z] 01:44:39     INFO - TEST-PASS | browser/components/migration/tests/browser/browser_dialog_cancel_close.js | Window was closed. - true == true - 
Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1987a6cc967c
Allow the MigrationWizard to close dialogs that it is embedded in. r=niklas
Status: NEW → RESOLVED
Closed: 16 days ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Flags: needinfo?(mconley)
You need to log in before you can comment on or make changes to this bug.