1809352 - Include branding assets for each browser that can be imported from

Status: RESOLVED FIXED

(Firefox :: Migration, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

The new migration dialog shows an icon for each browser that can be imported from. The simplest solution to display these is to include the branding in the omni.ja as graphic assets.

This bug tracks the work to both:

1. Retrieve and package the branding assets to browser/components/migration/content/brands
2. Update the MigratorBase base class to include a new getter that returns a chrome:// URI string to the appropriate branding asset

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: 128x128 browser icon assets

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Here's how to approach this bug:

1. Download and unzip the folder locally. Move the files into a new folder, browser/components/migration/content/brands, and use hg add to add them.
2. Update the migration component's jar.mn file to make sure we "package" the new images when we build Firefox. You can do that by adding this line:

	content/browser/migration/brands (content/brands/*.png)

3. Then, let's add a new static key to the MigratorBase class to be overridden by child classes, like this one. Let's call it brandImage or something, and have it return "chrome://global/skin/icons/defaultFavicon.svg" by default.
4. Update each subclass of MigratorBase to implement that static method, and return a string URL pointing to the appropriate image file. For example, for the SafariProfileMigrator, I think this would be "chrome://browser/content/migration/brands/safari.png".

Comment 3

[portiawuu]

Attachment: Bug 1809352- Include branding assets for each browser that can be imported from. r=mconley!,kpatenio!,niklas!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: 360 icon (128x128)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d45f0ddbd8b
Include branding assets for each browser that can be imported from. r=mconley

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures on browser_all_files_referenced.js

Backout link

Push with failures

Failure log

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: vivaldi.png

Looks like we also missed an icon for Vivaldi, so I'm attaching that here.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41710d48be48
Include branding assets for each browser that can be imported from. r=mconley

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/41710d48be48