Closed
Bug 1809359
Opened 1 year ago
Closed 1 year ago
Inline SetElementMegamorphic in Ion
Categories
(Core :: JavaScript Engine: JIT, enhancement, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
111 Branch
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: alexical, Assigned: alexical)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sp3])
Attachments
(1 file)
So, given that we have a cache for megamorphic gets, and SetElementMegamorphic calls are hot in speedometer, it seems like we could speed things up by populating a cache on SetElementMegamorphic VM calls, and utilizing that cache from Ion code. The cache would map shape and id to a (maybe) new shape and slot.
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
Severity: -- → N/A
Priority: -- → P1
|
||
Updated•1 year ago
|
Assignee: nobody → dothayer
Attachment #9311474 -
Attachment description: WIP: Bug 1809359 - Inline SetElementMegamorphic → Bug 1809359 - Inline SetElementMegamorphic r?jandem
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•1 year ago
|
||
The attached patch gets us a 4% win on React-TodoMVC, a 5% win on React-Redux-TodoMVC, a 4% win on React-Elm-TodoMVC, and possibly a 1% win on matrix-react-bench. (perfherder - sorry for the grandprixbench noise, also I think the medium confidence regressions from that are spurious.)
|
|
Assignee | |
Updated•1 year ago
|
Pushed by dothayer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8129ee5398d5 Inline SetElementMegamorphic r=jandem
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox111:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
|
||
Comment 5•1 year ago
|
||
Also seems to improve all AWFY-Elm-TodoMVC/* benchmarks
|
||
Updated•1 year ago
|
Whiteboard: [sp3]
|
||
Updated•1 year ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-224
You need to log in
before you can comment on or make changes to this bug.
Description
•