1809485 - test_punycodeURIs times out when run from an MSIX package

Status: NEW

(Firefox :: File Handling, defect, P5)

Description

[[e-mail] (:bhearsum)]

[task 2023-01-09T14:43:08.720Z] 14:43:08     INFO -  TEST-START | uriloader/exthandler/tests/unit/test_punycodeURIs.js
[task 2023-01-09T14:48:08.732Z] 14:48:08     INFO -  TEST-TIMEOUT | uriloader/exthandler/tests/unit/test_punycodeURIs.js | took 300013ms
[task 2023-01-09T14:48:08.737Z] 14:48:08     INFO -  xpcshell return code: None

Full log is available at https://treeherder.mozilla.org/jobs?repo=try&author=bhearsum%40mozilla.com&test_paths=uriloader%2Fexthandler%2Ftests%2Funit&fromchange=06efba7b77357f173e0eeedcda35960c81a4575c&selectedTaskRun=LH2IYjFSR2KmHm4cbI90JA.0 (although there's really nothing of note there).

If I had to guess, I'd say it's probably having trouble finding or launching at https://searchfox.org/mozilla-central/rev/a156a65ced2dae5913ae35a68e9445b8ee7ca457/uriloader/exthandler/tests/unit/test_punycodeURIs.js#122, as things are a little bit different inside of an MSIX environment for two reasons:

1. We cannot write to the install directory (which means we can't put support files there)
2. We run xpcshell tests through firefox.exe -xpcshell, so any assumptions made about the currently running process may not be valid.

Comment 1

[Marco Bonardo [:mak]]

Is there a way to run the tests locally, to make it easier to fix these tests?

here we're getting cwd and adding an executable, not sure why we use cwd
https://searchfox.org/mozilla-central/rev/a156a65ced2dae5913ae35a68e9445b8ee7ca457/uriloader/exthandler/tests/unit/test_punycodeURIs.js#86-88

Comment 2

[[e-mail] (:bhearsum)]

(In reply to Marco Bonardo [:mak] from comment #1)

Is there a way to run the tests locally, to make it easier to fix these tests?

here we're getting cwd and adding an executable, not sure why we use cwd
https://searchfox.org/mozilla-central/rev/a156a65ced2dae5913ae35a68e9445b8ee7ca457/uriloader/exthandler/tests/unit/test_punycodeURIs.js#86-88

It is....possible, although not necessarily easy (./mach test will not do it for you, as far as I know). I believe you should be able to run them locally by installing an MSIX build and then launching the test directly with something like:

C:\\Program Files\\WindowsApps\\Mozilla.MozillaFirefoxNightly_111.2301.2018.0_x64__5x4grbbqzn2q4\\VFS\\ProgramFiles\\MozillaFirefoxNightly Package Root\\firefox.exe --xpcshell -g C:\\Program Files\\WindowsApps\\Mozilla.MozillaFirefoxNightly_111.2301.2018.0_x64__5x4grbbqzn2q4\\VFS\\ProgramFiles\\MozillaFirefoxNightly Package Root -a C:\\Program Files\\WindowsApps\\Mozilla.MozillaFirefoxNightly_111.2301.2018.0_x64__5x4grbbqzn2q4\\VFS\\ProgramFiles\\MozillaFirefoxNightly Package Root -m -e const _HEAD_JS_PATH = "Z:/task_167423600920308/build/tests/xpcshell/head.js"; -e const _MOZINFO_JS_PATH = "C:\\\\Users\\\\task_167423600920308\\\\AppData\\\\Local\\\\Temp\\\\xpcshell\\\\xpcshellprofile\\\\mozinfo.json"; -e const _PREFS_FILE = "C:\\\\Users\\\\task_167423600920308\\\\AppData\\\\Local\\\\Temp\\\\xpc-other-4gjgyobs\\\\user.js"; -e const _TESTING_MODULES_DIR = "Z:\\\\task_167423600920308\\\\build\\\\tests\\\\modules\\\\"; -f Z:\\task_167423600920308\\build\\tests\\xpcshell\\head.js -e const _HEAD_FILES = []; -e const _JSDEBUGGER_PORT = 0; -e const _TEST_FILE = ["C:/Users/task_167423600920308/AppData/Local/Temp/tmpj5fows_7/test_add_task_stack_trace.js"]; -e const _TEST_NAME = "test_add_task_stack_trace.js"; -e _execute_test(); quit(0);

You can find the install directory by launching an admin powershell and heading over to c:\program files\windowsapps - that's got all the MSIX applications in it. You'll probably need to do some adjustment to the quotes and/or backslashes - that command is one that I logged from a test job on try

(In theory you can also launch with the xpcshell harness, but in practice there's a whole bunch of set-up you have to do with python deps, various artifacts, etc. that make it a real pain in the butt.)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:Gijs, could you have a look please?

For more information, please visit auto_nag documentation.