180951 - Profile directory never changes on profile switch

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, defect)

Description

[Conrad Carlen (not reading bugmail)]

Regression from my recent profile directory service provider refactoring. Patch
coming up. With this patch, the one Kai updated on bug 97622 works.

Comment 1

[Conrad Carlen (not reading bugmail)]

Attachment: patch

I think this code was expecting that, on a switch, the dir would be cleared to
nsnull first, then set to a new directory. Silly, and that's not what profile
mgr was doing.

Comment 2

[Kai Engert (:KaiE:)]

Thanks, I can confirm this patch makes profile switching from bug 97622 work on
Linux.

Comment 3

[Kai Engert (:KaiE:)]

That's weird, I did not add the keywords that were mentioned in the bugmail and
that I'm now removing - although the bugmail said so.

Comment 4

[Alec Flett]

Comment on attachment 106822 [details] [diff] [review]
patch

do we want to check if aProfileDir == mProfileDir
(or rather, if mProfileDir.Equals(aProfileDir,...) )

just to make sure we aren't doing extra work..

Comment 5

[Alec Flett]

Comment on attachment 106822 [details] [diff] [review]
patch

and actually, maybe have an NS_WARNING or NS_ASSERTION if they are equal, just
to warn developers if they've called it that way by accident.

Comment 6

[Conrad Carlen (not reading bugmail)]

There is a check in the profile mgr which happens way before it calls on this
object. But, the check is cheap and to cover the case of this object being used
standalone without profile mgr, I'll put a check in here as well.

Comment 7

[Conrad Carlen (not reading bugmail)]

Attachment: patch-2

Adds the equality check.

Comment 8

[Alec Flett]

Comment on attachment 107047 [details] [diff] [review]
patch-2

cool, yeah that was my concern.. sr=alecf

Comment 9

[Kai Engert (:KaiE:)]

Comment on attachment 107047 [details] [diff] [review]
patch-2

r=kaie

Comment 10

[Conrad Carlen (not reading bugmail)]

Fixed.

Comment 11

[Kai Engert (:KaiE:)]

Comment on attachment 106822 [details] [diff] [review]
patch

removing the "request review" flags on those patches because they show up in my
request report :)

Comment 12

[Grace Bush]

verified all platforms