1809519 - Enable the GPU sandbox in Release

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement, P1)

Description

[Chris Martin [:cmartin] - PTO back Oct 14]

The GPU sandbox has been enabled in Beta for a while, and all has been pretty quiet. Let's flip the switch and send it to release!

Comment 1

[Chris Martin [:cmartin] - PTO back Oct 14]

Attachment: Bug 1809519 - Enable the GPU sandbox in Release

Comment 2

[Pascal Chevrel:pascalc]

I am guessing that this will land in 110 before the soft code freeze, will that require QA? An addition to release notes? Thanks

Comment 3

[Chris Martin [:cmartin] - PTO back Oct 14]

Note that we are going to enable this in Release channel despite the fact that Bug 1799470 is unresolved. Though it may not be as strong of a sandbox, a weakened GPU sandbox is still an improvement over no sandbox at all. A fix for that bug is likely coming in the next release or two anyhow. (famous last words...)

Comment 4

[Chris Martin [:cmartin] - PTO back Oct 14]

(In reply to Pascal Chevrel:pascalc from comment #2)

I am guessing that this will land in 110 before the soft code freeze, will that require QA? An addition to release notes? Thanks

Yes, we are going to try and get it enabled in 110. I don't think that it will require any special QA, as a lot of this is going to end up being corner cases that we're going to run into on individual users' machine configurations, and I wouldn't even know what to ask of QA in addition to the usual testing.

Good call on the Release Notes though -- Definitely need to add that.

Comment 5

[Chris Martin [:cmartin] - PTO back Oct 14]

Release Note Request (optional, but appreciated)
[Why is this notable]: It might cause glitchy behavior, performance issues, or other difficult-to-anticipate behavior on user's machines
[Affects Firefox for Android]: No
[Suggested wording]: "GPU sandboxing has been enabled on Windows"
[Links (documentation, blog post, etc)]:

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/381ff7fccb6f
Enable the GPU sandbox in Release r=jrmuizel

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/381ff7fccb6f

Comment 8

[Pascal Chevrel:pascalc]

Note added to our Nightly and Beta notes, thanks.

Comment 9

[Chris Martin [:cmartin] - PTO back Oct 14]

Hi Pascal,

Could you please also add an additional note to the end of the previous release note for this:

Note: A bug in the popular X-Mouse Button Control (XMBC) tool may cause mouse wheel scrolling to stop working. The author(s) are working on an update.

Thanks!

Comment 10

[Pascal Chevrel:pascalc]

(In reply to Chris Martin [:cmartin] from comment #9)

Hi Pascal,

Could you please also add an additional note to the end of the previous release note for this:

Note: A bug in the popular X-Mouse Button Control (XMBC) tool may cause mouse wheel scrolling to stop working. The author(s) are working on an update.

Thanks!

Note added.

Comment 11

[Yannis Juglaret [:yannis]]

Could we also mention explicitly the existing fix in the note? We could add a link to bug 1798014 comment 78, or copy paste some of its content in the note; maybe the second option is more appropriate.

Comment 12

[Pascal Chevrel:pascalc]

(In reply to Yannis Juglaret from comment #11)

Could we also mention explicitly the existing fix in the note? We could add a link to bug 1798014 comment 78, or copy paste some of its content in the note; maybe the second option is more appropriate.

Please provide the exact wording you would like to have for the note, thanks.

Comment 13

[Yannis Juglaret [:yannis]]

Sure, sorry about that. I guess something like this, if Chris agrees?

Note: A bug in the popular X-Mouse Button Control (XMBC) tool may cause mouse wheel scrolling to stop working. The author(s) are working on an update. Meanwhile, scrolling can be restored by reconfiguring XMBC: either disable the Make scroll wheel scroll window under cursor option in the global settings, or enable the Disable scroll window under cursor option if using a custom profile for Firefox.

Comment 14

[Chris Martin [:cmartin] - PTO back Oct 14]

Thanks for bringing this up, Yannis, and for providing the wording -- Looks good to me! :)

Comment 15

[Pascal Chevrel:pascalc]

Note updated, will be live in 30mn.

Comment 16

[Pascal Chevrel:pascalc]

Added to final 110 notes.