1809622 - document referrer is always empty if page is served from SW

Status: ASSIGNED

(Core :: DOM: Service Workers, defect, P3)

Description

[Andrey]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36

Steps to reproduce:

1. Open https://17ggvi.csb.app/foo/index.html page
2. Reload page in order to activate SW (ServiceWorker)
3. Click to "5. away" link
4. Click to "1. foo" link
5. Evaluate "document.referrer" in the developer console. It will be empty.

Navigation request to page should be served via SW, it's important for reproducing this bug.

Actual results:

document.referrer is empty

Expected results:

document.referrer is not empty

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Andrey]

Related issues:

• https://bugzilla.mozilla.org/show_bug.cgi?id=1626192
• https://bugzilla.mozilla.org/show_bug.cgi?id=1628363
• https://bugzilla.mozilla.org/show_bug.cgi?id=1626616

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Thank you for providing a reproduction! Notes for future investigation to start from:

• The ServiceWorker https://17ggvi.csb.app/bar/sw.js is using workbox
• In general it looks like workbox should be performing a pass-through fetch of the form fetch(request, undefined) but that was just the first use of fetch I found.
• This matters because step 13.1 of the Request constructor will clobber the referrer if init is not empty and our code conforms to this behavior

if (aInit.IsAnyMemberPresent()) {
  request->SetReferrer(
      NS_LITERAL_STRING_FROM_CSTRING(kFETCH_CLIENT_REFERRER_STR));
  request->SetReferrerPolicy(ReferrerPolicy::_empty);
}

Comment 4

[Tibor Maerz]

I am writing to follow up on this open bug report as it continues to significantly impact our company’s work. Specifically, one of our customers relies on the document.referrer value to be set when navigating to subpages. However, when requests go through our service worker, this property is always empty, causing issues on our customer’s website.

We would greatly appreciate any assistance in resolving this issue as soon as possible.

Comment 6

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Hi Eden, please take this, thank you!

Comment 7

[Eden Chuang[:edenchuang]]

Attachment: Bug 1809622 - Propagating the referrerInfo back to child channel if the redirection is caused by ServiceWorker interception. r=#dom-worker-reviewers

Currently Firefox performs ServiceWorker interception by channel redirection.
It would cause a new channel for loading in the content process. However, ServiceWorker interception is different from the normal redirection, so the child channel lose the referrerInfo.

This patch tries to restore the content channel's referrerInfo by its coresponding InterceptedHttpChannel in parent.
When a ServiceWorker interception redirection happens, InterceptedHttpChannel's referrerInfo is propagated through RedirectToRealChannelArgs to the content process.