Closed
Bug 1809635
Opened 2 years ago
Closed 2 years ago
Somewhat safer usage of nsITreeView in nsTreeBodyFrame.
Categories
(Core :: Layout, task)
Core
Layout
Tracking
()
RESOLVED
FIXED
110 Branch
Tracking | Status | |
---|---|---|
firefox110 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-release-
|
Details | Review |
No description provided.
Assignee | ||
Comment 1•2 years ago
|
||
Not convinced this will help with bug 1809492, so different bug... But
these are places where I noticed we call nsITreeView from a member.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/acb661aab657 Somewhat safer usage of tree views in nsTreeBodyFrame. r=smaug
Comment 3•2 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox110:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
Assignee | ||
Comment 4•2 years ago
|
||
Comment on attachment 9311727 [details]
Bug 1809635 - Somewhat safer usage of tree views in nsTreeBodyFrame. r=smaug
Beta/Release Uplift Approval Request
- User impact if declined: Should fix or help with bug 1809492.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce: N/A
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Has been in the tree for a way, fairly low-risk patch.
- String changes made/needed: none
- Is Android affected?: No
Attachment #9311727 -
Flags: approval-mozilla-release?
Comment 5•1 year ago
|
||
Comment on attachment 9311727 [details]
Bug 1809635 - Somewhat safer usage of tree views in nsTreeBodyFrame. r=smaug
Crashes are still happening in 110.0b7, so it doesn't appear this patch fixed them unfortunately.
Attachment #9311727 -
Flags: approval-mozilla-release? → approval-mozilla-release-
You need to log in
before you can comment on or make changes to this bug.
Description
•