1809640 - Move WebExtension valid checks from SearchService to AddonSearchEngine

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

I want to start moving more of the add-on manager integration (getting policies for extensions, getting the manifest) into AddonSearchEngine.

Overall, I believe this will help to simplify the search service, and make it easier for AddonSearchEngine to handle its own changes and updates.

This bug is for the first part of that process - moving the current checks, for if the addon search engine is valid and matching the installed add-ons, to AddonSearchEngine.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1809640 - Move add-on search engine checks from the search service to AddonSearchEngine. r?#search-reviewers!

Depends on D166529

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a9f7afc3a03
Move add-on search engine checks from the search service to AddonSearchEngine. r=search-reviewers,daleharvey

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing failures on test_TelemetryEnvironment_search.js

Backout link

Push with failures

Failure log

Comment 4

[Mark Banner (:standard8)]

Test fixed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59622cf129dc
Move add-on search engine checks from the search service to AddonSearchEngine. r=search-reviewers,daleharvey

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/59622cf129dc