Closed Bug 1809640 Opened 2 months ago Closed 2 months ago

Move WebExtension valid checks from SearchService to AddonSearchEngine

Categories

(Firefox :: Search, task, P3)

Product:
Firefox
Component:
Search
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Bug 1809640 - Move add-on search engine checks from the search service to AddonSearchEngine. r?#search-reviewers!
48 bytes, text/x-phabricator-request
Details | Review

I want to start moving more of the add-on manager integration (getting policies for extensions, getting the manifest) into AddonSearchEngine.

Overall, I believe this will help to simplify the search service, and make it easier for AddonSearchEngine to handle its own changes and updates.

This bug is for the first part of that process - moving the current checks, for if the addon search engine is valid and matching the installed add-ons, to AddonSearchEngine.

Blocks: 1810766
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a9f7afc3a03
Move add-on search engine checks from the search service to AddonSearchEngine. r=search-reviewers,daleharvey

Backed out for causing failures on test_TelemetryEnvironment_search.js

Backout link

Push with failures

Failure log

Flags: needinfo?(standard8)

Test fixed.

Flags: needinfo?(standard8)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59622cf129dc
Move add-on search engine checks from the search service to AddonSearchEngine. r=search-reviewers,daleharvey

https://hg.mozilla.org/mozilla-central/rev/59622cf129dc

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.