1809673 - BYOB reader.read() never resolves when created from Response

Status: RESOLVED FIXED

(Core :: DOM: Streams, defect)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

await (async () => {
  const reader = new Response("HELLO").body.getReader({ mode: "byob" });
  let done;
  while (!done) {
    // await new Promise(setTimeout)
    const result = await reader.read(new Uint8Array(2));
    done = result.done;
    console.log(result);
  }
})()

Without setTimeout: 3 chunks "HE", "LL", "O" are read but then it stalls
With setTimeout: 1 chunk "HE" is read and then it ends, losing everything else.

Needs to be investigated.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1809673 - Part 1: Stop using stream internal algorithms from BodyStream r=tschuster,mgaudet,smaug

This adds some of the public helper functions for ReadableStream provided by the spec, that are needed for BodyStream.

Depends on D166534

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1809673 - Part 2: Add tests for BYOB readers from Response r=tschuster,mgaudet,smaug

Depends on D166663

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e164e4bbc2f
Part 1: Stop using stream internal algorithms from BodyStream r=smaug,evilpie
https://hg.mozilla.org/integration/autoland/rev/c03fafca6fb4
Part 2: Add tests for BYOB readers from Response r=smaug

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37910 for changes under testing/web-platform/tests

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7e164e4bbc2f
https://hg.mozilla.org/mozilla-central/rev/c03fafca6fb4

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by sideshowbarker