1809728 - redo processor notes so it only has notes from most recent processing

Status: RESOLVED FIXED

(Socorro :: Processor, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Currently, the processor_notes field is a string delimited by \n with processing passes denoted by a note like:

>>> Start processing: {start_time} ({self.host_id})

The processor notes are indexed in Elasticsearch.

This creates a couple of problems:

1. finding crash reports with a certain item in the notes brings up all the crash reports that have that certain item in any of the processing passes the crash report has undergone; so if you have a bug indicated by a certain item, fix the bug, and reprocess the crash report, it'll continue to show up in searches
2. the processor notes is a string blob of stuff and we're doing substring searches in it, but it'd be better if it had more structure to it like the collector notes do

I think I want to change it this way:

1. at the beginning of processing, prepend the existing processor_notes (string) value to processor_history (list of strings)
2. save notes generated during processing in processor_notes (string)

In this way, Elasticsearch only indexes the notes for the most recent processor pass, but we maintain notes for all passes in the processed crash.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6313: bug 1809728: implement processor_history

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6313: "bug 1809728: implement processor_history" in 523074f.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was pushed to prod just now in bug #1809927. Marking as FIXED.