1809828 - Jump Back In thumbnail image is not displayed sometimes

Status: RESOLVED FIXED

(Fenix :: Homepage, defect, P2)

Description

[Chris Peterson [:cpeterson]]

From github: https://github.com/mozilla-mobile/fenix/issues/24132.

Steps to reproduce

1. Open a few pages (especially wikipedia articles and addons pages).
2. Reopen a wikipedia article (other than the last accessed page) from Recently visited section.
3. Observe the Jump back in thumbnail image.

Expected behaviour

The Jump back in thumbnail image is displayed.

Actual behaviour

The Jump back in thumbnail image is not displayed.

Device name

Google Pixel 4

Android version

Android 12

Firefox release type

Firefox
Firefox Nightly

Firefox version

98.1.1
99.0a1 (2022-03-07)

Device logs

No response

Additional information

https://user-images.githubusercontent.com/48829350/157034283-d6e08b3a-f86e-47b7-9ee8-b4f2b89fde73.mp4

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1809828 - Display Tab Thumbnail when failing to download image (#3073)

Comment 3

[Vlad Dreghici [:vdreghici]]

I have investigated this issue and there are multiple layers here.
I have managed to reproduce it by accessing pocket stories from website thewalrus.ca . For most of the stories here, the image was too large and when trying to download it to use as thumbnail for jump back in, the download failed and the fallback was a white rectangle, that is why it seemed like the picture was not displayed sometimes. I came up with a fix for this in the PR attached.
The other interesting aspect is the fact that the same story had the image downloaded and shown correctly in the pocket stories section of the home page. After digging for a while, I discovered that this was due to the way the pocked API works, allowing us to request images for stories any width and height we want, as per example below:

For pocket, link is:

https://img-getpocket.cdn.mozilla.net/{wh}/filters:format(jpeg):quality(60):no_upscale():strip_exif()/https%3A%2F%2Fwalrus-assets.s3.amazonaws.com%2Fimg%2FTretheway_DeepestMap_1800_02.jpeg

this actually helps a lot, because it is possible to resize the image like this

https://img-getpocket.cdn.mozilla.net/319x231/filters:format(jpeg):quality(60):no_upscale():strip_exif()/https%3A%2F%2Fwalrus-assets.s3.amazonaws.com%2Fimg%2FTretheway_DeepestMap_1800_02.jpeg

Simply replacing {wh} from the raw link received into desired width and height.

We cannot do this with normal links, since it is a feature provided by pocket. The best next solution would be to just take a snapshot of the tab and display that as an image when it fails to download the actual image provided by the website.

Nevertheless, this would require UX approval.

Comment 4

[Vlad Dreghici [:vdreghici]]

Leaving an update here. This issue seems to have been fixed by the patch to Improve performance of tab thumbnail loading in Compose.

I have also talked with Kate about the behavior of the thumbnail and she sent me a figma design. I have tested the behavior and it follows the one described there.

Because of this, I will remove the need-ux tag and add qe-verify in order to make sure that this bug was fixed and it can be closed.

Comment 5

[Adina Petridean QA [:apetridean]]

Verified as fixed on the Nightly 120.0a1 from 26.09.2023 build.

The described issue is no longer reproducible on the mentioned build.

Devices used to verify:
Google Pixel 7 Pro ( Android 14)
Google Pixel 3 XL (Android 9)
Motorola Moto G9 plus (Android 11)

Comment 6

[Adina Petridean QA [:apetridean]]

Attachment: thumbnail.JPEG

Comment 7

[Vlad Dreghici [:vdreghici]]

Closing this as it was fixed in 1844967.