Closed Bug 1809912 Opened 2 years ago Closed 2 years ago

"Block" and "Resend" button are not properly aligned

Categories

(DevTools :: Netmonitor, defect, P3)

Product:
DevTools
Component:
Netmonitor
Type:
defect

Tracking

(firefox112 fixed)

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: nchevobbe, Assigned: khadija)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(3 files, 1 obsolete file)

block and resend button are not aligned
24.64 KB, image/png
Details
CleanShot 2023-02-21 at 16.59.47.png
156.97 KB, image/png
Details
Bug 1809912 - Apply same styling to Block and Resend buttons in Network Monitor
48 bytes, text/x-phabricator-request
Details | Review

See the screenshot, looks like there's a 1px difference which seems to come from the 1px bottom padding set in https://searchfox.org/mozilla-central/rev/893a8f062ec6144c84403fbfb0a57234418b89cf/devtools/client/netmonitor/src/assets/styles/HeadersPanel.css#33-36

.network-monitor .headers-panel-container #block-button.devtools-button {
  height: 19px;
  padding: 0 2px 1px;
}
Severity: -- → S3
Priority: -- → P3
Keywords: good-first-bug

Hey! I would like to work on this bug. Kindly assign it to me. :)

sure, it's yours :)

Assignee: nobody → kamrankhadijadj

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #2)

sure, it's yours :)

Hey Nicolas! Can you tell me where can I exactly find these two buttons? I am looking for them in my 'Web Development Tools' under the 'Network' tab. Thank you! :)

You need to click on a request, then on the Headers panel, they are in the top right corner

Okay found it! Thank you :)

Attachment #9319144 - Attachment description: WIP: Bug 1809912 - Removed 1px bottom padding for Block button in Network Monitor, so that it aligns with Resend button. Made changes in HeadsPanel.css file. → WIP: Bug 1809912 - Removed 1px bottom padding for Block button in Network Monitor, so that it aligns with Resend button.
Attachment #9319144 - Attachment description: WIP: Bug 1809912 - Removed 1px bottom padding for Block button in Network Monitor, so that it aligns with Resend button. → WIP: Bug 1809912 - Removed 1px bottom padding for Block button in Network Monitor, so that it aligns with Resend button. Made changes in HeadsPanel.css file.
Attachment #9319191 - Attachment description: WIP: Bug 1809912 - Applying the same style for the "Resend" button as "Block" button so they have the same height and padding → Bug 1809912 - Applying the same style for the "Resend" button as "Block" button so they have the same height and padding
Attachment #9319191 - Attachment is obsolete: true
Attachment #9319144 - Attachment description: WIP: Bug 1809912 - Removed 1px bottom padding for Block button in Network Monitor, so that it aligns with Resend button. Made changes in HeadsPanel.css file. → WIP: Bug 1809912 - Removed 1px bottom padding and applied the style to Block and Resend button in Network Monitor, so that both buttons align. Made changes in HeadsPanel.css file.
Attachment #9319144 - Attachment description: WIP: Bug 1809912 - Removed 1px bottom padding and applied the style to Block and Resend button in Network Monitor, so that both buttons align. Made changes in HeadsPanel.css file. → Bug 1809912 - Apply same styling to Block and Resend buttons in Network Monitor
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e4d0dac7f34f Apply same styling to Block and Resend buttons in Network Monitor r=nchevobbe

https://hg.mozilla.org/mozilla-central/rev/e4d0dac7f34f

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Duplicate of this bug: 1754370
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: