1809941 - In some case pretty-printing still produces long lines

Status: VERIFIED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Go to https://ffx-devtools-pretty-print.glitch.me/
2. Open the debugger
3. Select the cases/long-lines.js file
4. Click the Pretty print icon

Expected results

Those long lines gets chopped-up into multiple, smaller ones

Actual results

The lines are still long after pretty printing

---

It looks like we could do a better job when expressions are separated by && or || (especially when we're not in a if condition)
We could also have better output for ternary conditions

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1809941 - [devtools] Add line break after parens when content is long. r=#devtools-reviewers.

When dealing with a ( token, we check the next tokens to find the matching
closing paren. In the same time, we compute the length of all the tokens inside
the paren.
If we reach a given length (60 at the moment) without finding the closing paren,
we consider it "long" and will treat it (and the closing paren) as line delimiter.
On top of that, we expand line delimiters to || and && when there not in a
"short" paren, so we can split up long lines.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9f77a7cf26b
[devtools] Add line break after parens when content is long. r=devtools-reviewers,bomsy.

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for dt failure on browser_dbg-pretty-print-inline-scripts.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/c4b9ae0face44b20202b0d90393e408b86336e34
Log link: https://treeherder.mozilla.org/logviewer?job_id=412700138&repo=autoland&lineNumber=4167

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

ah sorry, i thought I fixed it at some point 🤔

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62af6f051232
[devtools] Add line break after parens when content is long. r=devtools-reviewers,bomsy.

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/62af6f051232

Comment 7

[Ina Popescu, Desktop QA]

I've reproduced this issue using Nightly 114.0a1 (2023-04-15) on Windows 10 x64 following the STR from Comment 0.
Verified as fixed on the latest Firefox 114.0b3 version on Windows 10, macOS 13 and Ubuntu 22.04, where the issue no longer persists.