1809946 - make `moz-phab reorg` use `stackGraph` instead of calls to `edge.search`

Status: RESOLVED FIXED

(Conduit :: moz-phab, enhancement)

Description

[Connor Sheehan [:sheehan]]

moz-phab reorg queries the edge.search endpoint multiple times to determine the state of the stack graph on Phabricator.

Since bug 1787517 we have had this information available in the differential.revision.search response. We should parse that information to reduce the number of API calls to Phabricator during moz-phab reorg.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: reorg: use `all` instead of checking for `None in` (Bug 1809946) r?grammar,zeid

Comment 2

[Connor Sheehan [:sheehan]]

Attachment: reorg: clarify language in "new commit found" error message (Bug 1809946) r?grammar,zeid

Depends on D166714

Comment 3

[Connor Sheehan [:sheehan]]

Attachment: reorg: add a docstring for `reorganise` command function (Bug 1809946) r?grammar,zeid

Depends on D166715

Comment 4

[Connor Sheehan [:sheehan]]

Attachment: reorg: use `stackGraph` revision field to determine stack instead of `edge.search` (Bug 1809946) r?grammar,zeid

Phabricator now includes a stackGraph field in its responses
to differential.revision.search Conduit API calls. Update
moz-phab reorg to use this data instead of calling edge.search
many times in succession.

Add a validate_stackgraph_linear function that converts the
data from the Phabricator format into a linear linked list
representing the graph. Update tests to mock this new function
and add tests for the new function. Remove get_stack from
conduit.py as it is unused after this change.

Depends on D166716

Comment 5

[Connor Sheehan [:sheehan]]

Attachment: reorg: remove `v = v` no-op and clarify variable names (Bug 1809946) r?grammar,zeid

Remove an unnecessary if statement that only executes a no-op
assignment when the condition is true. Also rename variables to
more useful names.

Depends on D166717

Comment 6

[Connor Sheehan [:sheehan]]

Attachment: reorg: add some variable names for lists in various loops (Bug 1809946) r?grammar,zeid

Create proper variable names for lists being looped over.
Also re-use one loop as its value is never modified and
the same loop is created twice unnecessarily.

Depends on D166718