make `moz-phab reorg` use `stackGraph` instead of calls to `edge.search`
Categories
(Conduit :: moz-phab, enhancement)
Tracking
(Not tracked)
People
(Reporter: sheehan, Assigned: sheehan)
References
Details
Attachments
(6 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
moz-phab reorg
queries the edge.search
endpoint multiple times to determine the state of the stack graph on Phabricator.
Since bug 1787517 we have had this information available in the differential.revision.search
response. We should parse that information to reduce the number of API calls to Phabricator during moz-phab reorg
.
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
Depends on D166714
Assignee | ||
Comment 3•2 years ago
|
||
Depends on D166715
Assignee | ||
Comment 4•2 years ago
|
||
Phabricator now includes a stackGraph
field in its responses
to differential.revision.search
Conduit API calls. Update
moz-phab reorg
to use this data instead of calling edge.search
many times in succession.
Add a validate_stackgraph_linear
function that converts the
data from the Phabricator format into a linear linked list
representing the graph. Update tests to mock this new function
and add tests for the new function. Remove get_stack
from
conduit.py
as it is unused after this change.
Depends on D166716
Assignee | ||
Comment 5•2 years ago
|
||
Remove an unnecessary if
statement that only executes a no-op
assignment when the condition is true. Also rename variables to
more useful names.
Depends on D166717
Assignee | ||
Comment 6•2 years ago
|
||
Create proper variable names for lists being looped over.
Also re-use one loop as its value is never modified and
the same loop is created twice unnecessarily.
Depends on D166718
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Description
•