Closed Bug 18100 Opened 21 years ago Closed 21 years ago

Plain Text reply doesn't break line

Categories

(MailNews Core :: Composition, defect, P3)

PowerPC
All
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: akkzilla)

Details

When I reply to a message (original message is either plain text or HTML) in
plain text mode, the whole quoted body appears in on line without any line
breaks. I have the problem today on Mac but not on Windows.
Status: NEW → ASSIGNED
Summary: [PP]Plain Text reply doesn't break line → Plain Text reply doesn't break line
Target Milestone: M12
I don't think this is really a PP bug.  At least, I see the problem on Windows
as well.

It turns out that plaintext quoting is completely screwed up in lots of ways:
1. someone broke the plaintext quotation code in the editor
2. someone else disabled it so that plaintext quotations get put in as html
blockquotes
3. someone else accidentally removed the places in the editor shell where the
editor type was being set, so we don't actually have a good record of whether
we're a plaintext or html editor any more.

All these things need to be fixed.  I have at least partial fixes, which will be
checked in as soon as the tree opens for M12.
OS: Mac System 8.6 → All
Blocks: 18471
Assignee: akkana → rhp
Status: ASSIGNED → NEW
Rich: I've checked in the fixes for the plaintext editor, and I've verified that
if I change line 128 of nsMsgCompose.cpp from
<   if ( (aQuoted) && (aHTMLEditor) )
to
>   if ( (aQuoted) )
the message is quoted correctly, at least on Linux.

Sending this bug back to you to decide whether it's kosher to check in that
change to nsMsgCompose (should probably remove the comment, too :-).  Or I can
check it in if you'd rather, but I didn't want to check it in without your ok.
That would be great if you can check in the changes for nsMsgCompose.cpp. I'm
knee deep in a compose back end issue so this would really help out.

- rhp
Assignee: rhp → akkana
Okay, taking the bug back, and I have checked in the changes and will close the
bug.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Linux Redhat 6.0 (1999-11-10-17 M11)
Win Nt 4.0 (1999-11-10-17 M11)
Mac (1999-11-10-17 M11)
Plain text reply has break line now.
No longer blocks: 18471
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.